Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CDN WAF support. #9014

Merged
merged 17 commits into from
Dec 13, 2019
Merged

Add CDN WAF support. #9014

merged 17 commits into from
Dec 13, 2019

Conversation

fore5fire
Copy link
Contributor

@fore5fire fore5fire commented Dec 5, 2019 •
edited
Loading

pilor and others added 4 commits December 5, 2019 18:03
@pilor @isra-fel
Generate 2019-09-01 policy operations (Azure#8927)
9c11f73 
* Generate 2019-09-01 policy operations

* Update generate and build artifacts

* Fixed generation metadata
@annelo-msft
TextAnalytics API Refactoring (Azure#8905)
24a8f2e 
* move errors to document result

* api updates per feedback

* Remove interface

* Include Statistics

* updates per API feedback

* shift to result collections

* TextAnalysisOptions

* reenable recognize entity single

* reenable recognize entity batch

* reenable key phrases

* reenable remaining

* API feedback

* bug fix

* pr feedback

* pr feedback
@christothes @pakrym
Make the AzureServiceTokenProvider mockable (Azure#8464)
a8607ef
@danieljurek
Update Smoke Tests for October GA release (Azure#8639)
dcd2803 
* update package versions to match published GA packages

* update to incorporate ga interface changes

* update KV interface

* remove pinned versions for packages that aren't targeted in smoke tests
@fore5fire fore5fire requested a review from erich-wang as a code owner December 5, 2019 23:02
danielmarbach and others added 9 commits December 5, 2019 16:45
@danielmarbach @nemakam
Bump to ApiApprover 10.0.1 (Azure#8982)
26e6644 
Brings up to speed with PublicApiGenerator 10.0.1 which supports nullable reference types and has more stable member sorting
@schaabs
Fixing UsernamePasswordCredential constructor parameter missordering (A…
ebcf6ce 
…zure#8997)

* Fixing UsernamePasswordCredential constructor parameter misordering

* adding missed file

* exclude header x-client-OS from header matching

* excluding x-client-OS and x-client-SKU from header matching

* Refactoring RecordedTestSanitizer to enable higher level sanitiation

* updates to sanitize test recordings

* removing hard coded RecordedTestMode

* Fix to RecordEntry serialization

* addressing PR feedback'
@jsquire
[Event Hubs Client] Track Two (Samples and Documentation) (Azure#9011)
7d2c2d8 
The focus of these changes is to revise the samples for the Event Processor
client, extend the set of samples with additional scenarios and flesh out the
README content for the samples in each package.

Also included are some small refinements to the Event Processor client that
were deferred from feedback for an earlier pull request, a fix for an empty
partition context when the maximum wait time elapses, and ignoring a
test that requires follow-up analysis.
@weshaggard
Update package index links in README.md (Azure#9015)
9d7fd14 
Package index is now controlled centrally in the azure-sdk repo
https://github.com/Azure/azure-sdk/blob/master/_data/releases/latest/dotnet-packages.csv
@annelo-msft
Text Analytics AAD Support (Azure#9007)
948b7f7 
* first try at aad

* un-update sample

* fix

* fix
@AlexanderSher
Update release notes (Azure#9013)
073e784 
* Update release notes

* Update CHANGELOG.md

Add link to the fixed bug
@chidozieononiwu
Checkin Doc Index to Master (Azure#8791)
e1bafbe
@JoshLove-msft
ensure UserDelegationKey test doesn't use UTC (Azure#9024)
ddb1bdf
@danieljurek
remove reflection (Azure#9021)
f08bb6d
@isra-fel isra-fel self-assigned this Dec 9, 2019
@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Dec 9, 2019
isra-fel
isra-fel suggested changes Dec 9, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lsmith130 , could you

  • Add a link to the swagger spec review PR in the description
  • Update api tag in AzSdk.RP.props
  • Update tests

Thanks

sdk/cdn/Microsoft.Azure.Management.Cdn/src/Properties/AssemblyInfo.cs Outdated Show resolved Hide resolved
@isra-fel isra-fel assigned fore5fire and unassigned isra-fel Dec 9, 2019
@anponnet @isra-fel
Releasing latest version of Microsoft.DataBoxEdge SDK (Azure#9008)
8886546 
* Releasing latest version of Microsoft.DataBoxEdge SDK

* Generated code through generate.cmd

* Update Microsoft.Azure.Management.DataBoxEdge.csproj

* Generate sdk using generate.ps1 command and address review comments

* Update Microsoft.Azure.Management.DataBoxEdge.csproj
@nemakam nemakam removed their request for review December 9, 2019 18:52
@fore5fire
Copy link
Contributor Author

Hi @lsmith130 , could you

  • Add a link to the swagger spec review PR in the description
  • Update api tag in AzSdk.RP.props
  • Update tests

Thanks

The API tag in AzSdk.RP.props was already updated to the preview version in master in an earlier PR. I'll leave it as-is here and fix it to be the stable API version in master.

The other requested changes, adding the swagger spec review PR links, updating the Assembly version, and updating the tests have all been done.

@fore5fire fore5fire requested review from isra-fel and removed request for JoshLove-msft December 12, 2019 00:27
@isra-fel isra-fel assigned isra-fel and unassigned fore5fire Dec 12, 2019
@isra-fel isra-fel merged commit 6427c8c into Azure:cdn-preview Dec 13, 2019
@isra-fel
Copy link
Member

isra-fel commented Dec 13, 2019 •
edited
Loading

@lsmith130 please don't sync up with master in a feature PR, makes it hard to review.
You can do that in a seperate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@amnguye amnguye Awaiting requested review from amnguye amnguye is a code owner

@annelo-msft annelo-msft Awaiting requested review from annelo-msft annelo-msft is a code owner

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu chidozieononiwu is a code owner

@danieljurek danieljurek Awaiting requested review from danieljurek danieljurek is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

@kinelski kinelski Awaiting requested review from kinelski kinelski is a code owner

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

@pakrym pakrym Awaiting requested review from pakrym

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@serkantkaraca serkantkaraca Awaiting requested review from serkantkaraca serkantkaraca is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

Assignees

@isra-fel isra-fel

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.