Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate 2019-09-01 policy operations #8927

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Conversation

pilor
Copy link
Contributor

@pilor pilor commented Nov 26, 2019

Re-generate SDK classes for Microsoft.Authorization/policy* entities.

Generated from the package-policy-2019-09 tag here: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/resources/resource-manager

@pilor pilor requested a review from erich-wang as a code owner November 26, 2019 19:32
@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Dec 3, 2019
@isra-fel isra-fel self-assigned this Dec 3, 2019
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pilor , could you

  • Include the .txt file generated when you run generate.ps1(details)
  • Update api tag in AzSdk.RP.props

Thanks

@pilor
Copy link
Contributor Author

pilor commented Dec 3, 2019

@isra-fel Done. Updating the tools and following those docs (instead of old methods which I was following) generated the content successfully.

@isra-fel
Copy link
Member

isra-fel commented Dec 4, 2019

Hi this file SDKs/_metadata/resources_resource-manager.txt is in the wrong path. Should be eng/mgmt/mgmtmetadata/resources_resource-manager.txt.

@pilor
Copy link
Contributor Author

pilor commented Dec 4, 2019

Hi this file SDKs/_metadata/resources_resource-manager.txt is in the wrong path. Should be eng/mgmt/mgmtmetadata/resources_resource-manager.txt.

@isra-fel, I found the problem. If you enable the new MSIT Onedrive backup of your desktop the target that installs the updated Powershell modules puts them in the wrong location. It is placing them in C:\Users\cheggert\Documents\WindowsPowerShell\Mo
dules instead of C:\Users\cheggert\OneDrive - Microsoft\Documents\WindowsPowerShell\Modules which is where Powershell is looking for modules. Therefore, my old modules from last year were still being used. I'll push the correct metadata file in a sec.

@isra-fel isra-fel merged commit 9c11f73 into Azure:master Dec 5, 2019
@pilor pilor deleted the policy20190901 branch December 5, 2019 17:21
isra-fel pushed a commit that referenced this pull request Dec 13, 2019
* Generate 2019-09-01 policy operations (#8927)

* Generate 2019-09-01 policy operations

* Update generate and build artifacts

* Fixed generation metadata

* TextAnalytics API Refactoring (#8905)

* move errors to document result

* api updates per feedback

* Remove interface

* Include Statistics

* updates per API feedback

* shift to result collections

* TextAnalysisOptions

* reenable recognize entity single

* reenable recognize entity batch

* reenable key phrases

* reenable remaining

* API feedback

* bug fix

* pr feedback

* pr feedback

* Make the AzureServiceTokenProvider mockable (#8464)

* Update Smoke Tests for October GA release (#8639)

* update package versions to match published GA packages

* update to incorporate ga interface changes

* update KV interface

* remove pinned versions for packages that aren't targeted in smoke tests

* Bump to ApiApprover 10.0.1 (#8982)

Brings up to speed with PublicApiGenerator 10.0.1 which supports nullable reference types and has more stable member sorting

* Fixing UsernamePasswordCredential constructor parameter missordering (#8997)

* Fixing UsernamePasswordCredential constructor parameter misordering

* adding missed file

* exclude header x-client-OS from header matching

* excluding x-client-OS and x-client-SKU from header matching

* Refactoring RecordedTestSanitizer to enable higher level sanitiation

* updates to sanitize test recordings

* removing hard coded RecordedTestMode

* Fix to RecordEntry serialization

* addressing PR feedback'

* [Event Hubs Client] Track Two (Samples and Documentation) (#9011)

The focus of these changes is to revise the samples for the Event Processor
client, extend the set of samples with additional scenarios and flesh out the
README content for the samples in each package.

Also included are some small refinements to the Event Processor client that
were deferred from feedback for an earlier pull request, a fix for an empty
partition context when the maximum wait time elapses, and ignoring a
test that requires follow-up analysis.

* Update package index links in README.md (#9015)

Package index is now controlled centrally in the azure-sdk repo
https://github.com/Azure/azure-sdk/blob/master/_data/releases/latest/dotnet-packages.csv

* Text Analytics AAD Support (#9007)

* first try at aad

* un-update sample

* fix

* fix

* Update release notes (#9013)

* Update release notes

* Update CHANGELOG.md

Add link to the fixed bug

* Checkin Doc Index to Master (#8791)

* ensure UserDelegationKey test doesn't use UTC (#9024)

* remove reflection (#9021)

* Update GoogleAdWords and GoogleBigQuery clientId for fix issue (#9019)

* [DataFactory]Add SAP HANA partition settings (#9032)

* Releasing latest version of Microsoft.DataBoxEdge SDK (#9008)

* Releasing latest version of Microsoft.DataBoxEdge SDK

* Generated code through generate.cmd

* Update Microsoft.Azure.Management.DataBoxEdge.csproj

* Generate sdk using generate.ps1 command and address review comments

* Update Microsoft.Azure.Management.DataBoxEdge.csproj

* Regenerate CDN for API version 2019-06-15-preview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants