Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs Client] Track Two: Second Preview (Samples) … #7123

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

jsquire
Copy link
Member

@jsquire jsquire commented Aug 5, 2019

Summary

The intent of these changes is enhance the samples to cover the new scenarios added for preview two and improve upon the existing set of samples.

Last Upstream Rebase

Tuesday, August 6, 2019 9:090am (EDT)

Resources

Related and Follow-Up Issues

@jsquire jsquire added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Aug 5, 2019
@jsquire jsquire added this to the Sprint 156 milestone Aug 5, 2019
@jsquire jsquire self-assigned this Aug 5, 2019
@jsquire jsquire force-pushed the eventhubs/tr2p2/samples branch from dde4606 to 6c5cb65 Compare August 5, 2019 22:12
@jsquire jsquire force-pushed the eventhubs/tr2p2/samples branch 3 times, most recently from 234d01b to 1e26020 Compare August 6, 2019 13:56
Copy link
Member

@kinelski kinelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

    Samples
      - Tweaked the sample harness program to allow for double digit samples,
        which required some changes to display and input for prompts.

      - Continued seek and destroy for spelling and grammar errors.

      - Reformatted sample indexing to force 2 characters in order to ensure
        that sorting works as expected.

      - Reindexed samples, organizing a new batch publishing sample near the existing
        publishing samples and attempting to adhere to the approach of samples for a
        context building in complexity.

      - Converted simple consumption scenarios to an iterator-based approach, adding
        samples to illustrate the iterator scenarios.

      - Created a placeholder sample for the event processor.
@jsquire jsquire force-pushed the eventhubs/tr2p2/samples branch from 1e26020 to 0e39b3d Compare August 6, 2019 15:38
@jsquire jsquire merged commit 9dff740 into Azure:master Aug 6, 2019
@jsquire jsquire deleted the eventhubs/tr2p2/samples branch August 6, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants