Add resource group based LTR APIs + tests to azure sdk #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixia
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
|
Let's aim to publish this and #6934 together |
jaredmoo
suggested changes
Jul 18, 2019
| // Get the backups under the resource group, server and database. Assert there are no backups returned. | ||
| // | ||
| IPage<LongTermRetentionBackup> backups = sqlClient.LongTermRetentionBackups.ListByResourceGroupLocation(resourceGroup.Name, server.Location); | ||
| Assert.True(backups.Count() == 0); |
There was a problem hiding this comment.
Why do you care how many backups are returned? Don't you just want the API to succeed (i.e. not throw)?
| string resourceGroupName = ""; | ||
| string serverName = ""; | ||
| string databaseName = ""; | ||
| string locationName = "brazilsouth"; |
There was a problem hiding this comment.
discussed offline, added comments and keep the change so test could pass in playback mode
| @@ -312,7 +333,7 @@ public void TestLongTermRetentionV2Crud() | |||
| // | |||
| Microsoft.Azure.Management.Sql.Models.BackupLongTermRetentionPolicy parameters = new Microsoft.Azure.Management.Sql.Models.BackupLongTermRetentionPolicy(weeklyRetention: "P2W"); | |||
| var policyResult = sqlClient.BackupLongTermRetentionPolicies.CreateOrUpdateWithHttpMessagesAsync(resourceGroupName, serverName, databaseName, parameters).Result; | |||
| sqlClient.GetPutOrPatchOperationResultAsync(policyResult, new Dictionary<string, List<string>>(), CancellationToken.None).Wait(); | |||
| Assert.Equal(System.Net.HttpStatusCode.OK, policyResult.Response.StatusCode); | |||
| @@ -364,7 +385,7 @@ public void TestLongTermRetentionV2Crud() | |||
| // | |||
| parameters = new Microsoft.Azure.Management.Sql.Models.BackupLongTermRetentionPolicy(weeklyRetention: "P1W"); | |||
| policyResult = sqlClient.BackupLongTermRetentionPolicies.CreateOrUpdateWithHttpMessagesAsync(resourceGroupName, serverName, databaseName, parameters).Result; | |||
| sqlClient.GetPutOrPatchOperationResultAsync(policyResult, new Dictionary<string, List<string>>(), CancellationToken.None).Wait(); | |||
| Assert.Equal(System.Net.HttpStatusCode.OK, policyResult.Response.StatusCode); | |||
| // Set the weekly retention on the database so that the first backup gets picked up | ||
| // Wait about 18 hours until it gets properly copied and you see the backup when run get backups | ||
| // | ||
| string locationName = "brazilsouth"; |
There was a problem hiding this comment.
Please clear out the names
There was a problem hiding this comment.
discussed offline will keep the change
| // Verify the backup is gone. | ||
| // | ||
| backups = sqlClient.LongTermRetentionBackups.ListByResourceGroupDatabase(resourceGroupName, locationName, serverName, databaseName); | ||
| Assert.True(backups.Count() == 0); |
| // Delete the backup. | ||
| // | ||
| var deleteResult = sqlClient.LongTermRetentionBackups.DeleteByResourceGroupWithHttpMessagesAsync(resourceGroupName, locationName, serverName, databaseName, backup.Name).Result; | ||
| Assert.Equal(System.Net.HttpStatusCode.OK, deleteResult.Response.StatusCode); |
There was a problem hiding this comment.
Why are you checking statuscode? generate client internals already check the status code. I don't think that this is a detail that you really care about at this layer.
There was a problem hiding this comment.
You could just call sqlClient.LongTermRetentionBackups.DeleteByResourceGroup(...) and let the generated SDK do its own validation
erich-wang
suggested changes
Jul 18, 2019
|
Done |
erich-wang
approved these changes
Jul 18, 2019
jaredmoo
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.