Failover database and elastic pools Net SDK #6934
Conversation
emgu-ms
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
| @@ -13,6 +13,7 @@ | |||
| <
There was a problem hiding this comment.
Line 15 is release notes for 1.31.0-preview, this was already published (see https://www.nuget.org/packages/Microsoft.Azure.Management.Sql). So you should update version to 1.32 (here and in AssemblyInfo.cs) and wipe out the old release notes.
| Assert.NotNull(db); | ||
|
|
||
| // Failover database | ||
| AzureOperationResponse failoverResponse = await sqlClient.Databases.BeginFailoverWithHttpMessagesAsync( |
There was a problem hiding this comment.
just call Failover instead, that way you are verifying the entire e2e operation succeeds.
| Assert.NotNull(db); | ||
|
|
||
| // Failover elastic pool | ||
| AzureOperationResponse failoverResponse = await sqlClient.ElasticPools.BeginFailoverWithHttpMessagesAsync( |
| @@ -13,6 +13,7 @@ | |||
| <![CDATA[ | |||
| New features: | |||
| - Added support for serverless databases. | |||
| - Added support for failover databases and elastic pools. | |||
| ]]> | |||
| </PackageReleaseNotes> | |||
| </PropertyGroup> | |||
There was a problem hiding this comment.
@emgu-ms, you need to update Version if you want to publish new nuget pcakge
There was a problem hiding this comment.
You may also need update the value of AssemblyFileVersion in AssemblyInfo.cs
| @@ -12,6 +12,7 @@ | |||
| <PackageReleaseNotes> | |||
| <
REST API commit change - Azure/azure-rest-api-specs@597f7dd#diff-cf76f9fb3a55909fa9cd42d1e4612784
Added database and elastic pool failover to Net SDK. Also included tests.