Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mgmt yml file #6623

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Update mgmt yml file #6623

merged 1 commit into from
Jun 20, 2019

Conversation

weshaggard
Copy link
Member

Update mgmt yml file to be closer to client yml file
still needs to be separate until we can get the mgmt tooling
to work with dotnet pack/test commands.

Added eng/mgmt.proj which builds all mangment libraries.
Updated root build.proj to include both mgmt and client libraries.

PTAL @shahabhijeet @mitchdenny @chidozieononiwu

<Import Project="Directory.Build.props" />
<Import Project="Directory.Build.targets" />
<Project Sdk="Microsoft.Build.Traversal">
<ItemGroup>
Copy link
Member

@shahabhijeet shahabhijeet Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard won't it be easy for now until everything settles down where we have
instead of build.proj, we create
mgmt.proj
<takeYourPick>.proj (for non-mgmt projects)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have that which is eng/service.proj

@weshaggard
Copy link
Member Author

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@weshaggard
Copy link
Member Author

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@shahabhijeet
Copy link
Member

@weshaggard I updated mgmt.yml last night as there were couple of PRs that wanted me to review/merge, so I excluded SDK directory, hence you see the conflict for that file.

@weshaggard weshaggard force-pushed the wesh/updatemgmtyml branch 2 times, most recently from 3979504 to 27e9f59 Compare June 19, 2019 22:11
@weshaggard weshaggard force-pushed the wesh/updatemgmtyml branch 5 times, most recently from 39fa9f5 to 4958579 Compare June 20, 2019 17:15
Update mgmt yml file to be closer to client yml file
still needs to be separate until we can get the mgmt tooling
to work with dotnet pack/test commands.

Added eng/mgmt.proj which builds all mangment libraries.
Updated root build.proj to include both mgmt and client libraries.

Remove init step from old mgmt.yml as it is needed any longer

Add scope path validation

Add support for publishing property
@weshaggard weshaggard force-pushed the wesh/updatemgmtyml branch from 4958579 to 88f304b Compare June 20, 2019 17:37
@weshaggard weshaggard merged commit ef0bccf into master Jun 20, 2019
@weshaggard weshaggard deleted the wesh/updatemgmtyml branch June 20, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants