Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SdkCommon -> mgmtcommon #6584

Merged
merged 5 commits into from
Jun 20, 2019
Merged

Move SdkCommon -> mgmtcommon #6584

merged 5 commits into from
Jun 20, 2019

Conversation

chidozieononiwu
Copy link
Member

Move SdkCommon -> mgmtcommon

@chidozieononiwu
Copy link
Member Author

chidozieononiwu commented Jun 13, 2019 •
edited
Loading

/azp run azure-sdk-for-net - mgmt

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@chidozieononiwu
Copy link
Member Author

@Azure/azure-sdk-eng

shahabhijeet
shahabhijeet suggested changes Jun 14, 2019
View reviewed changes
Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dozie we do not need sdkcommon directory inside mgmtcommon
the sole reason we created mgmtcommon, because of the feedback from @weshaggard that there should not be anything like sdkcommon
So it's better if we simply move all the directories into mgmtcommon

@chidozieononiwu
Copy link
Member Author

Dozie we do not need sdkcommon directory inside mgmtcommon
the sole reason we created mgmtcommon, because of the feedback from @weshaggard that there should not be anything like sdkcommon
So it's better if we simply move all the directories into mgmtcommon

I have it updated now

@chidozieononiwu chidozieononiwu force-pushed the MoveSDKCommon_2 branch 4 times, most recently from 3858f80 to b1fcb9e Compare June 17, 2019 22:55
@shahabhijeet
Copy link
Member

@chidozieononiwu can you disable running the tests that is failing to run.
I will have to fix it once this PR is merged.

@shahabhijeet shahabhijeet merged commit 45cdad6 into Azure:master Jun 20, 2019
@weshaggard
Copy link
Member

@shahabhijeet this change broke the full client CI builds. I'm fixing that as part of #6623.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chidozieononiwu @shahabhijeet @weshaggard