-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# SDK change with Hub's certificate and operation tasks #3847
Changes from 6 commits
7acbaa6
7400e9c
f75482a
ab93cf8
aac7529
0912dc8
da3f8ac
c3d5e3d
ecb65bd
2ca835f
9167c87
d4aa98b
d3ad7da
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<configuration> | ||
<packageSources> | ||
<!-- To enable LocalFeed for testing uncomment the following line --> | ||
<add key="NugetOfficialV3" value="https://api.nuget.org/v3/index.json" /> | ||
<add key="Local" value="tools/LocalNugetFeed" /> | ||
</packageSources> | ||
<!-- To enable LocalFeed for testing uncomment the following line --> | ||
<add key="NugetOfficialV3" value="https://api.nuget.org/v3/index.json" /> | ||
<add key="Local" value="tools/LocalNugetFeed" /> | ||
</packageSources> | ||
</configuration> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,13 +4,17 @@ | |
<PackageId>IotHub.Tests</PackageId> | ||
<Description>IotHub.Tests Class Library</Description> | ||
<AssemblyName>IotHub.Tests</AssemblyName> | ||
<VersionPrefix>1.0.1-preview</VersionPrefix> | ||
<VersionPrefix>1.0.2-preview</VersionPrefix> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
<TargetFrameworks>netcoreapp1.1</TargetFrameworks> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
<GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
</PropertyGroup> | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @anusapan please use latest version of Resource manager to record all your tests. You are still using 1.1.0, latest version is 1.6.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added new references of ResourceManager and recorded test again |
||
<ItemGroup> | ||
<PackageReference Include="Microsoft.Azure.Management.EventHub" Version="1.2.0" /> | ||
<PackageReference Include="Microsoft.Azure.Management.ServiceBus" Version="0.2.0-preview" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,5 +35,5 @@ | |
// You can specify all the values or you can default the Build and Revision Numbers | ||
// by using the '*' as shown below: | ||
// [assembly: AssemblyVersion("1.0.*")] | ||
[assembly: AssemblyVersion("1.0.0.1")] | ||
[assembly: AssemblyFileVersion("1.0.0.1")] | ||
[assembly: AssemblyVersion("1.0.0.2")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @anusapan AssemblyVersion only changes when you update the Major version. Please do not update AssemblyVersion and make it same as AssemblyFileVersion There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reverted |
||
[assembly: AssemblyFileVersion("1.0.0.2")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anusapan what is the need to edit this file? All this is doing is deleting spaces. Can you revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted