C# SDK change with Hub's certificate and operation tasks #3847
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
|
NuGet.Config
Outdated
| <add key="NugetOfficialV3" value="https://api.nuget.org/v3/index.json" /> | ||
| <add key="Local" value="tools/LocalNugetFeed" /> | ||
| </packageSources> | ||
| <!-- To enable LocalFeed for testing uncomment the following line --> |
There was a problem hiding this comment.
@anusapan what is the need to edit this file? All this is doing is deleting spaces. Can you revert this change.
| @@ -35,5 +35,5 @@ | |||
| // You can specify all the values or you can default the Build and Revision Numbers | |||
| // by using the '*' as shown below: | |||
| // [assembly: AssemblyVersion("1.0.*")] | |||
| [assembly: AssemblyVersion("1.0.0.1")] | |||
| [assembly: AssemblyFileVersion("1.0.0.1")] | |||
| [assembly: AssemblyVersion("1.0.0.2")] | |||
There was a problem hiding this comment.
@anusapan AssemblyVersion only changes when you update the Major version. Please do not update AssemblyVersion and make it same as AssemblyFileVersion
| <PackageTags>Microsoft Azure IotHub;IotHub management;IotHub;REST HTTP client;azureofficial;windowsazureofficial;netcore451511</PackageTags> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net452;netstandard1.4</TargetFrameworks> | ||
| </PropertyGroup> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
@anusapan you do not need this property anymore, so please remove it. If you get in the upstream changes, this will no longer be needed.
| <PropertyGroup> | ||
| <GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
| </PropertyGroup> | ||
|
|
There was a problem hiding this comment.
@anusapan please use latest version of Resource manager to record all your tests. You are still using 1.1.0, latest version is 1.6.0
YOU will have add reference to the new nuget, use the namespace from the new nuget and remove all traces of old namespace and then record your tests.
There was a problem hiding this comment.
added new references of ResourceManager and recorded test again
|
@azuresdkci test this please |
| @@ -5,7 +5,7 @@ | |||
| <Description>Provides management capabilities for Microsoft Azure IotHub.</Description> | |||
| <AssemblyTitle>Microsoft Azure IotHub Management</AssemblyTitle> | |||
| <AssemblyName>Microsoft.Azure.Management.IotHub</AssemblyName> | |||
| <VersionPrefix>1.1.2</VersionPrefix> | |||
| <VersionPrefix>1.1.3</VersionPrefix> | |||
| <PackageTags>Microsoft Azure IotHub;IotHub management;IotHub;REST HTTP client;azureofficial;windowsazureofficial;netcore451511</PackageTags> | |||
There was a problem hiding this comment.
@anusapan can you add package release notes like below
https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/BatchAI/Management.BatchAI/Microsoft.Azure.Management.BatchAI.csproj#L10
There was a problem hiding this comment.
added PackageReleaseNotes.
|
@azuresdkci retest this please |
|
@azuresdkci test this please |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Description
Regenerated the SDK based off a new swagger and add/update the test cases for updated SDK.
Updated swagger PR
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.