[Azs.Fabric.Admin] Regenerate. New Test. Recorded Sessions. Bug Fix. #3729
Conversation
…new test. There was a bug in the OpenAPI spec
|
@deathly809, |
| @@ -25,5 +25,5 @@ | |||
| // You can specify all the values or you can default the Build and Revision Numbers | |||
| // by using the '*' as shown below: | |||
| // [assembly: AssemblyVersion("1.0.*")] | |||
| [assembly: AssemblyVersion("0.1.0.0")] | |||
| [assembly: AssemblyFileVersion("0.1.0.0")] | |||
| [assembly: AssemblyVersion("0.1.1.0")] | |||
There was a problem hiding this comment.
Please do not update assembly version when you change AssemblyFileVersion.
Keep it as 0.1.0.0
| @@ -4,4 +4,4 @@ | |||
| :: | |||
|
|
|||
| @echo off | |||
| call %~dp0..\..\..\..\tools\generate.cmd azsadmin/resource-manager/fabric latest Azure current azure-rest-api-specs %CD% | |||
| call %~dp0..\..\..\..\tools\generate.cmd azsadmin/resource-manager/fabric latest deathly809 current azure-rest-api-specs %CD% | |||
There was a problem hiding this comment.
do you have the update meta data txt file that get's generated as part of this generated code?
Also we do not allow you to generate code in public repo from your fork.
Generate from main REST API spec fork.
There was a problem hiding this comment.
@shahabhijeet What metadata file? I have never included any metadata files in my PRs and it is not mentioned anywhere in the readme.md. If there is something that needs to be done with this file then it should be included in the PR process instructions. Please update the instructions.
|
@shahabhijeet Fixed the stuff. I cannot reopen. |
Had an error in the OpenAPI spec. Fixed that and regenerated the C#. Added two new tests and re-recorded all session data. I have updated the version from 0.1.0 to 0.1.1 since this is just a bug fix.
Azure/azure-rest-api-specs#1720