Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureStack: Fixed incorrect return type and set to long running operation #1720

Merged
merged 2 commits into from
Sep 22, 2017

Conversation

deathly809
Copy link
Member

@deathly809 deathly809 commented Sep 21, 2017

Two changes:

  1. Fixed wrong return type
  2. Added long running operation flag

Before when executed the return type was IpPool which contained no initialized fields.
In addition, this is a long running operation.

Could not test before because RP was unstable when creating Ip Pools and would crash duh to exception.

@msftclas
Copy link

@deathly809,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/azsadmin/resource-manager/fabric/readme.md
Before the PR: Warning(s): 3 Error(s): 3
After the PR: Warning(s): 3 Error(s): 6

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/azsadmin/resource-manager/fabric/readme.md
Before the PR: Warning(s): 3 Error(s): 3
After the PR: Warning(s): 3 Error(s): 6

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@deathly809
Copy link
Member Author

@jhendrixMSFT Is there an estimate on the time to review/merge?

@jhendrixMSFT jhendrixMSFT merged commit a929984 into Azure:current Sep 22, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants