[AzureMonitorExporter] Fix how arrays stored in Activity Tags are serialized. #34086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in the way we serialize some arrays stored Activity Tags.
For example:
this would be serialized as key: "intArray" value: "1,2,3".
However,
this is being serialized as key: "intArray" value: "System.Int32[]"
The fix here is to consistently check for Array type and serialize the component items.
Changes
Array.ToCommaDelimitedString()
to serialize an Array as a comma delimited string.This copies the implementation from
AzMonList
'sTagEnumerationState
to use in theTraceHelper
.Screenshot