[OperationalInsights] Fix DateTimeOffset format string #34031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
requested review from
archerzz,
ArcturusZhang,
Yao725 and
ArthurMa1978
as code owners
|
API change check API changes are not detected in this pull request. |
Yao725
approved these changes
Feb 10, 2023
sdk/operationalinsights/Azure.ResourceManager.OperationalInsights/src/autorest.md
Show resolved
Hide resolved
glharper
added a commit
that referenced
this pull request
Feb 15, 2023
Co-authored-by: Jesse Squire <[email protected]> Co-authored-by: archerzz <[email protected]> Co-authored-by: Reiley Yang <[email protected]> Co-authored-by: Jesse Squire <[email protected]> Co-authored-by: HarmanDhunna <[email protected]> Co-authored-by: HarmanDhunna <[email protected]> Co-authored-by: Richard Park <[email protected]> Co-authored-by: Mike Harder <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Arcturus Zhang <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Yao Kou <[email protected]> Co-authored-by: ArcturusZhang <[email protected]> Co-authored-by: Vishwesh Bankwar <[email protected]> Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: Scott Addie <[email protected]> Co-authored-by: Madalyn Redding <[email protected]> Co-authored-by: Anne Thompson <[email protected]> Co-authored-by: Jose Arriaga Maldonado <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Scott Schaab <[email protected]> Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: ShivangiReja <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Timothy Mothra <[email protected]> Co-authored-by: ShaneMicro <[email protected]> Co-authored-by: Feng Zhou <[email protected]> Co-authored-by: nisha-bhatia <[email protected]> Co-authored-by: Nathan Carlson <[email protected]> Co-authored-by: wangrui-msft <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Arthur Ma <[email protected]> Co-authored-by: isolenov <[email protected]> Co-authored-by: m-nash <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]> Co-authored-by: Caio Saldanha <[email protected]> Co-authored-by: Chengming <[email protected]> Co-authored-by: Minghao Chen <[email protected]> Co-authored-by: Alexey Rodionov <[email protected]> Co-authored-by: Travis Wilson <[email protected]> Fix typo in Identity changelog (#34022) fix logic workflow update method (#33944) fixes #33975 by reformatting snippets in sdk/core. fix datetimeoffset format string (#34031) Fix creat recognize request of call automation media (#34036) Fix how arrays stored in Activity Tags are serialized. (#34086) fix more nullables (#34092) resolver, logic, storage (#34140) fix MSI deserialization (#34136) resolver releases (#34144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #33536, #33571
The generated code should be
property.Value.GetDateTimeOffset("O")instead ofproperty.Value.GetDateTimeOffset().The former method will call an extension method of
JsonElementwritten by us to treat theJsonElementas Int64 (Unix Timestamp) or string and the string case can support multiple formats despite the "O" format (ISO8601) being passed in. See code.The latter method calls the original
GetDateTimeOffset()ofJsonElementand seems to only supportISO8601format.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.