[Azure.Communication.Common] Added support for rawId ⟷ CommunicationIdentifier conversion #28574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check for API changes have been detected in |
|
API change check for API changes are not detected in this pull request for |
petrsvihlik
changed the title
petrsvihlik
commented
May 6, 2022
sdk/communication/Azure.Communication.Common/src/CommunicationIdentifier.cs
Show resolved
Hide resolved
|
API change check for API changes are not detected in this pull request for |
|
API change check for API changes are not detected in this pull request for |
petrsvihlik
requested review from
KrzysztofCwalina,
tg-msft,
JoshLove-msft,
christothes and
annelo-msft
as code owners
iaulakh
reviewed
May 9, 2022
sdk/communication/Azure.Communication.Common/src/PhoneNumberIdentifier.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Common/src/PhoneNumberIdentifier.cs
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Common/src/PhoneNumberIdentifier.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Common/src/PhoneNumberIdentifier.cs
Show resolved
Hide resolved
iaulakh
reviewed
May 20, 2022
sdk/communication/Azure.Communication.Common/src/CommunicationIdentifier.cs
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
AikoBB
reviewed
Jun 17, 2022
sdk/communication/Azure.Communication.Common/src/CommunicationIdentifier.cs
Show resolved
Hide resolved
AikoBB
approved these changes
Jun 24, 2022
zhihaoxue
pushed a commit
to zhihaoxue/azure-sdk-for-net
that referenced
this pull request
Jul 27, 2022
…dentifier conversion (Azure#28574) * Added support for rawId<->CommunicationIdentifier conversion * fixed tests * fixed compiler suggestions * updated generated api surface * fixed tests + added serialization of rawid for communication user * fixing recordings Azure#1 - for chat * update recordings with serialized rawId * add a changelog record for rawId (de)serialization * adjusted comments * gethashcode adjustments * lazy property init * updated api * testing that CommunicationIdentifier subclasses implement RawId
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
…dentifier conversion (Azure#28574) * Added support for rawId<->CommunicationIdentifier conversion * fixed tests * fixed compiler suggestions * updated generated api surface * fixed tests + added serialization of rawid for communication user * fixing recordings Azure#1 - for chat * update recordings with serialized rawId * add a changelog record for rawId (de)serialization * adjusted comments * gethashcode adjustments * lazy property init * updated api * testing that CommunicationIdentifier subclasses implement RawId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
The
CommunicationIdentifierdesign provides a good abstraction of Azure Communication Services internal id format with better type safety, auto-complete and hides internal knowledge.However, it doesn't lend well to storing identifiers in a database or using them as keys because there is no clear canonical way how to encode them. This PR introduces translation functions that lets developers use the underlying
rawIdfor these purposes.Details Internal wiki
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
See the Internal wiki
Are there test cases added in this PR?
Provide a list of related PRs (if any)
Checklists