[CommunicationIdentifier] Added support for rawId ⟷ CommunicationIdentifier conversion #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
I'm off. @AikoBB can you pls take a look? :) |
AikoBB
approved these changes
May 24, 2022
vcolin7
reviewed
May 24, 2022
...ommon/src/main/java/com/azure/android/communication/common/MicrosoftTeamsUserIdentifier.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/com/azure/android/communication/common/MicrosoftTeamsUserIdentifier.java
Show resolved
Hide resolved
...ation-common/src/main/java/com/azure/android/communication/common/PhoneNumberIdentifier.java
Show resolved
Hide resolved
petrsvihlik
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
approved with the same comment/question as for java - Azure/azure-sdk-for-java#28997 (comment)
This reverts commit 014e8d4.
As per discussion, we will keep this as check style enforce this rule. |
|
@petrsvihlik please find PR for doc #1139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CommunicationIdentifierdesign provides a good abstraction of Azure Communication Services internal id format with better type safety, auto-complete and hides internal knowledge.However, it doesn't lend well to storing identifiers in a database or using them as keys because there is no clear canonical way how to encode them. This PR introduces translation functions that lets developers use the underlying raw ID for these purposes.
Details Internal wiki
This PR closely follows the Java PR.
No REST changes.
All SDK Contribution checklist: