Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a number of small test issues with Core, Key Vault #27311

Merged
merged 4 commits into from
Mar 2, 2022

Conversation

heaths
Copy link
Member

@heaths heaths commented Mar 2, 2022

Fixes #27310
Fixes #11634
Relates to Azure/azure-sdk-tools#2434

Copy link
Member

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Framework changes look good

Copy link
Member

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KV changes look good as well

@heaths heaths enabled auto-merge (squash) March 2, 2022 22:53
@heaths heaths merged commit 07b03d3 into Azure:main Mar 2, 2022
@heaths heaths deleted the keyvault-tests branch March 3, 2022 00:35
yanfa317 pushed a commit to yanfa317/azure-sdk-for-net that referenced this pull request Mar 8, 2022
* Normalize LinkBase for Azure.Core shared files

* Revert changes for Azure/azure-sdk-tools#2434

* Compare recorded bodies

Seems in the course of creating predictable results, I inadvertently fixed Azure#11634.

* Don't enumerate JsonPathSanitizers twice

Fixes Azure#27310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We add from JsonPathSanitizers twice Investigate enabling request body matching in CertificateTests
2 participants