Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Key Vault tests to use common base class #27367

Closed
heaths opened this issue Mar 4, 2022 · 1 comment
Closed

Refactor Key Vault tests to use common base class #27367

heaths opened this issue Mar 4, 2022 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-enhancement
Milestone

Comments

@heaths
Copy link
Member

heaths commented Mar 4, 2022

The Key Vault live tests' base classes are mostly the same, so it'd be worth maintaining a single base class extending RecordedTestBase that had all the clean-up logic in it with a few abstract methods to delete/purge a key/secret/cert and create a client. When changes are necessary like they were recently in PR #27311 they would only need to be done in one place, typically.

@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. test-enhancement labels Mar 4, 2022
@heaths heaths added this to the [2022] April milestone Mar 4, 2022
@heaths heaths self-assigned this Mar 4, 2022
@jsquire jsquire modified the milestones: [2022] April, Backlog Apr 15, 2022
@heaths heaths modified the milestones: Backlog, [2022] May Apr 15, 2022
@heaths heaths modified the milestones: [2022] May, Backlog Apr 19, 2022
@heaths
Copy link
Member Author

heaths commented Jul 20, 2023

I don't believe there's enough value to prioritize this.

@heaths heaths closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-enhancement
Projects
Archived in project
Development

No branches or pull requests

2 participants