Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview of WebPubSub with RequestContext #25063

Closed
wants to merge 1 commit into from
Closed

Preview of WebPubSub with RequestContext #25063

wants to merge 1 commit into from

Conversation

annelo-msft
Copy link
Member

No description provided.

@ghost ghost added the Azure.Core label Nov 1, 2021
@check-enforcer
Copy link

check-enforcer bot commented Nov 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core.Experimental. You can review API changes here

@annelo-msft annelo-msft closed this Nov 3, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Aug 22, 2023
@pdaru @NickKeller
@jaiveerk @jatakiajanvi12 @matthchr @wenjungaogaogao @norshtein @sallasindhuja @huizhifan @SanyaKochhar
CodeGen from PR 25254 in Azure/azure-rest-api-specs
5519e82 
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-07-02-preview (Azure#25254)

* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-06-02-preview to version 2023-07-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#25049)

* add new field resourceUID to managed cluster properties (Azure#25069)

* add new field resourceUID to managed cluster properties

https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp/pullrequest/8416789

* update description

* Mark guardrailsProfile Version as not required (Azure#25081)

* Mark guardrailsProfile Version as not required

* Run prettier

---------

Co-authored-by: Nick Keller <[email protected]>

* Swagger Changes for Multiple DNS Zones for Web App Routing (Azure#25064)

* added web app routing changes for multiple dns zones

* modified examples

* Changes for unified azuremonitorprofile in Microsoft.ContainerService (Azure#25063)

* Changes for unified azuremonitorprofile

* Update prettier changes

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

---------

Co-authored-by: Janvi Jatakia (from Dev Box) <[email protected]>
Co-authored-by: FumingZhang <[email protected]>

* Add cost analysis to AKS preview Swagger (Azure#25082)

* update preview API to follow GA api - use one forceupgrade boolean in… (Azure#25099)

* update preview API to follow GA api - use one forceupgrade boolean instead of multiple overrides

* update msg

---------

Co-authored-by: Wenjun Gao <[email protected]>

* Mark trusted access role binding PUT and DELETE operation as async (Azure#25112)

* Mark trusted access role binding PUT and DELETE operation as async

* fix CI: update TA oepration's error to common type error

* Swagger for Machine API (Azure#25180)

* Swagger for Machine List, Get API

Related work items: #24759018

* Update managedClusters.json

* Update managedClusters.json

* Update MachineGet.json

adding new line

* Update MachineList.json

* Update managedClusters.json

* Update managedClusters.json

* Update managedClusters.json

* swagger: machine api

* swagger: machine api

* swagger:machine api

* swagger: machine api

* swagger: machine api

* swagger: machine api

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json

Co-authored-by: FumingZhang <[email protected]>

* swagger: machine api

* swagger: machine api

* swagger:  machine api

* swagger:machine api

* swagger:machine api

* swagger:machine api

---------

Co-authored-by: FumingZhang <[email protected]>

* Adding Guardrails version to public swagger (Azure#25085)

* Adding Guardrails version to public swagger

* renamed GetGuardrailsVersions.json

* Applied GetCollectionResponseSchema rule

* Ran prettier fix

* Minor change

* moving parametre into managedClusters.json

* GuardrailsAvailableVersion model change

* Updated version param reference

* Swagger SemanticValidation fix

* model changes

* prettier fix

* Added version in list response

* Changed  to resource in GET and added descriptions where needed

* Removed identifier in GuardrailsAvailableVersionsList

---------

Co-authored-by: Sindhuja Salla <[email protected]>

* Remove overlay vpa unused properties (Azure#25242)

* remove unused properties

* only remove from required section

* remove the whole properties

---------

Co-authored-by: zhifanhui <[email protected]>

* asm: update examples to use asm- prefix for revisions (Azure#25247)

* Revert "Mark trusted access role binding PUT and DELETE operation as async (Azure#25112)" (Azure#25233)

This reverts commit db24ef8bfbf6b214310af0872a923130e27ae1b6.

* fix AgentPoolNameParameter location

* Fuming zhang containerservice microsoft.container service 2023 07 02 preview (Azure#25433)

* adding requested properties.

* adding requested properties

* prettier check

* removing read-only constraint

---------

Co-authored-by: daru__ <[email protected]>
Co-authored-by: Nick Keller <[email protected]>
Co-authored-by: Nick Keller <[email protected]>
Co-authored-by: Jaiveer Katariya <[email protected]>
Co-authored-by: Janvi Jatakia <[email protected]>
Co-authored-by: Janvi Jatakia (from Dev Box) <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
Co-authored-by: Wenjun Gao <[email protected]>
Co-authored-by: Wenjun Gao <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: sushmak295 <[email protected]>
Co-authored-by: sallasindhuja <[email protected]>
Co-authored-by: Sindhuja Salla <[email protected]>
Co-authored-by: huizhifan <[email protected]>
Co-authored-by: zhifanhui <[email protected]>
Co-authored-by: Sanya Kochhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicancy vicancy Awaiting requested review from vicancy vicancy will be requested when the pull request is marked ready for review vicancy is a code owner

@JialinXin JialinXin Awaiting requested review from JialinXin JialinXin will be requested when the pull request is marked ready for review JialinXin is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina will be requested when the pull request is marked ready for review KrzysztofCwalina is a code owner

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annelo-msft @azure-sdk