Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyClient.GetCryptographyClient should return a local/remote hybrid client #25254

Closed
heaths opened this issue Nov 10, 2021 · 0 comments · Fixed by #25269
Closed

KeyClient.GetCryptographyClient should return a local/remote hybrid client #25254

heaths opened this issue Nov 10, 2021 · 0 comments · Fixed by #25269
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] December

Comments

@heaths
Copy link
Member

heaths commented Nov 10, 2021

...that's only true for the CryptographyClient constructed through the public constructors, not for the one returns by GetCryptographyClient (both remoteprovder & provider are set to the RemoteCryptographyClient)?

Originally posted by @dxynnez in #23786 (comment)
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 10, 2021
@heaths heaths self-assigned this Nov 10, 2021
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Nov 10, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 10, 2021
@heaths heaths added this to the [2021] December milestone Nov 10, 2021
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Nov 11, 2021
@heaths
Let KeyResolver cache key
88fb971 
Resolves Azure#25254
@heaths heaths mentioned this issue Nov 11, 2021
Merged
heaths added a commit that referenced this issue Nov 16, 2021
@heaths
Cache key from KeyClient.GetCryptographyClient (#25269)
7e98067 
* Let KeyResolver cache key

Resolves #25254

* Do not attempt to re-download forbidden key

* Resolve feedback, update CHANGELOG
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] December
Development

Successfully merging a pull request may close this issue.

Cache key from KeyClient.GetCryptographyClient heaths/azure-sdk-for-net
1 participant
@heaths