[Event Hubs Client] Fix Flaky Processor Test #21441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
christothes,
pakrym,
AlexGhiondea,
conniey and
serkantkaraca
|
Should we instead fix the test not to return null from |
pakrym
approved these changes
Jun 1, 2021
It's a fair point; we don't have anything in production code paths that should be |
jsquire
force-pushed
the
eventhubs/flaky-test
branch
from
a08f07f to
f9550a6
Compare
The focus of these changes is to fix a flaky test resulting from a recent change to the sequence of events when an event processor is closed.
jsquire
force-pushed
the
eventhubs/flaky-test
branch
from
f9550a6 to
1abe1da
Compare
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Dec 16, 2022
[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2022-11-01-preview (Azure#21441) * Adds base for updating Microsoft.DataProtection from version preview/2022-10-01-preview to version 2022-11-01-preview * Updates readme * Updates API version in new specs and examples * Added API changes for Blob Backup * Updated class descriptions based on the feedback * Fixing spellcheck errors * Removing "timedout" from custom-words.txt and adding to cSpell.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to fix a flaky test resulting from a change introduced by #21242 that caused a race condition in the test. This fix removes the assumption that a transport consumer is non-null and closes conditionally.
References and Related