[Event Hubs Client] Processor Stop - Aborts Links #21242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
christothes,
AlexGhiondea,
serkantkaraca and
JoshLove-msft
jsquire
force-pushed
the
eventhubs/processor-cancel
branch
from
d7cb633 to
def1208
Compare
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
//cc: @danielmarbach |
christothes
approved these changes
May 20, 2021
jsquire
changed the title
...venthub/Azure.Messaging.EventHubs.Processor/tests/Processor/EventProcessorClientLiveTests.cs
Show resolved
Hide resolved
...venthub/Azure.Messaging.EventHubs.Processor/tests/Processor/EventProcessorClientLiveTests.cs
Outdated
Show resolved
Hide resolved
...venthub/Azure.Messaging.EventHubs.Processor/tests/Processor/EventProcessorClientLiveTests.cs
Show resolved
Hide resolved
...venthub/Azure.Messaging.EventHubs.Processor/tests/Processor/EventProcessorClientLiveTests.cs
Show resolved
Hide resolved
JoshLove-msft
approved these changes
May 20, 2021
jsquire
force-pushed
the
eventhubs/processor-cancel
branch
from
def1208 to
20da85a
Compare
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The focus of these changes is to detect that an event processor is attempting to stop and force-close the AMQP links being used to read events. This should help to avoid pauses when stopping due to an active AMQP operation in the transport consumer being blocked because no events were available.
jsquire
force-pushed
the
eventhubs/processor-cancel
branch
from
20da85a to
2b179cf
Compare
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM |
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to detect that an event processor is attempting to stop and force-close the AMQP links being used to read events. This should help to avoid pauses when stopping due to an active AMQP operation in the transport consumer being blocked waiting for its timeout because no events were available.
References and Related