Update healthcareapis #19510
Update healthcareapis #19510
Conversation
peizhou298
requested review from
allenjzhang,
bquantump,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
| /// <param name="privateEndpointConnections">The list of private | ||
| /// endpoint connections that are set up for this resource.</param> | ||
| /// <param name="publicNetworkAccess">Control permission for data plane | ||
| /// traffic coming from public networks while private endpoint is | ||
| /// enabled. Possible values include: 'Enabled', 'Disabled'</param> | ||
| public ServicesProperties(string provisioningState = default(string), IList<ServiceAccessPolicyEntry> accessPolicies = default(IList<ServiceAccessPolicyEntry>), ServiceCosmosDbConfigurationInfo cosmosDbConfiguration = default(ServiceCosmosDbConfigurationInfo), ServiceAuthenticationConfigurationInfo authenticationConfiguration = default(ServiceAuthenticationConfigurationInfo), ServiceCorsConfigurationInfo corsConfiguration = default(ServiceCorsConfigurationInfo), ServiceExportConfigurationInfo exportConfiguration = default(ServiceExportConfigurationInfo), IList<PrivateEndpointConnection> privateEndpointConnections = default(IList<PrivateEndpointConnection>), string publicNetworkAccess = default(string)) | ||
| public ServicesProperties(string provisioningState = default(string), IList<ServiceAccessPolicyEntry> accessPolicies = default(IList<ServiceAccessPolicyEntry>), ServiceCosmosDbConfigurationInfo cosmosDbConfiguration = default(ServiceCosmosDbConfigurationInfo), ServiceAuthenticationConfigurationInfo authenticationConfiguration = default(ServiceAuthenticationConfigurationInfo), ServiceCorsConfigurationInfo corsConfiguration = default(ServiceCorsConfigurationInfo), ServiceExportConfigurationInfo exportConfiguration = default(ServiceExportConfigurationInfo), ServiceAcrConfigurationInfo acrConfiguration = default(ServiceAcrConfigurationInfo), IList<PrivateEndpointConnection> privateEndpointConnections = default(IList<PrivateEndpointConnection>), string publicNetworkAccess = default(string)) |
There was a problem hiding this comment.
this will result in a breaking change, new parameters should be appended to the end
| @@ -47,7 +47,7 @@ public partial interface IPrivateEndpointConnectionsOperations | |||
| /// <exception cref="Microsoft.Rest.ValidationException"> | |||
| /// Thrown when a required parameter is null | |||
| /// </exception> | |||
| Task<AzureOperationResponse<IEnumerable<PrivateEndpointConnection>>> ListByServiceWithHttpMessagesAsync(string resourceGroupName, string resourceName, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken)); | |||
| Task<AzureOperationResponse<IEnumerable<PrivateEndpointConnectionDescription>>> ListByServiceWithHttpMessagesAsync(string resourceGroupName, string resourceName, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken)); | |||
There was a problem hiding this comment.
This name doesn't seem ideal given that "Description" typically refers to a human friendly sentence which describes something. It appears all we wanted to do was add SystemData to an existing model, can we explore adding this directly to the PrivateEndpointConnection object instead of creating a new type?
There was a problem hiding this comment.
In my understanding, this code is generated automatically, change the code will cause the error in CI.
|
…dk-for-net into update-healthcareapis
|
Added comments on the spec PR showing where the breaking change is coming from Azure/azure-rest-api-specs#12125 (review) |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run net - mgmt - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Spec PR here Azure/azure-rest-api-specs@745f3e5 |
|
/check-enforcer evaluate |
ghost
added
the
no-recent-activity
|
Hi @peizhou298. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
closed this
|
Hi @peizhou298. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
new servicelabel and/or contact assigned reviewer.Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.