Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2021-01-11 #12125

Conversation

moria97
Copy link
Contributor

@moria97 moria97 commented Dec 15, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@moria97 moria97 requested a review from lirenhe as a code owner December 15, 2020 13:07
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 15, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 2 Warnings warning [Detail]

Rule Message
⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_CreateOrUpdate' Request Model: 'PrivateEndpointConnection' Response Model: 'PrivateEndpointConnectionDescription'
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L536
⚠️ R4021 - DescriptionAndTitleMissing 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L947
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 22 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

Rule Message
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed?
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L1332:3
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L885:3
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L330:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L327:9
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L202:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L199:9
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L151:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L148:9
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L247:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L244:9
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L410:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L407:9
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L94:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L91:9
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L364:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L361:9
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L49:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L49:9
⚠️ 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L287:9
Old: Microsoft.HealthcareApis/preview/2018-08-20-preview/healthcare-apis.json#L284:9
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 11 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

Rule Message
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L519:13
Old: Microsoft.HealthcareApis/stable/2020-03-30/healthcare-apis.json#L519:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L1312:11
Old: common-types/resource-management/v1/privatelinks.json#L144:11
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L710:13
Old: Microsoft.HealthcareApis/stable/2020-03-30/healthcare-apis.json#L710:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L1324:11
Old: common-types/resource-management/v1/privatelinks.json#L156:11
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L571:13
Old: Microsoft.HealthcareApis/stable/2020-03-30/healthcare-apis.json#L571:13
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'type' renamed or removed?
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L1280:7
Old: common-types/resource-management/v1/privatelinks.json#L20:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L1280:7
Old: common-types/resource-management/v1/privatelinks.json#L20:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'id' renamed or removed?
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L1294:7
Old: common-types/resource-management/v1/privatelinks.json#L100:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L1294:7
Old: common-types/resource-management/v1/privatelinks.json#L100:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'type' renamed or removed?
New: Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json#L1294:7
Old: common-types/resource-management/v1/privatelinks.json#L100:7
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 15, 2020

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from a501906. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md
  • ️✔️@azure/arm-healthcareapis [View full logs]  [Release SDK Changes]
    cmderr	[npmPack] loaded rollup.config.js with warnings
    cmderr	[npmPack] (!) Unused external imports
    cmderr	[npmPack] default imported from external module 'rollup' but never used
    cmderr	[npmPack] ./esm/healthcareApisManagementClient.js → ./dist/arm-healthcareapis.js...
    cmderr	[npmPack] created ./dist/arm-healthcareapis.js in 354ms
️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from a501906. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md
  • ️✔️azure-mgmt-healthcareapis [View full logs]  [Release SDK Changes]
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-healthcareapis
    cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-healthcareapis
    cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.healthcareapis
    cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.healthcareapis
    cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.healthcareapis
    cmderr	[changelogReport] INFO:__main__:Report written to sdk/healthcareapis/azure-mgmt-healthcareapis/code_reports/latest/report.json
    cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-healthcareapis on PyPI
    cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0b1']
    cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
    cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-healthcareapis in a venv
    cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
    cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.healthcareapis
    cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.healthcareapis
    cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.healthcareapis
    cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/healthcareapis/azure-mgmt-healthcareapis/code_reports/0.2.0/report.json
    cmdout	[Changelog] Size of delta 18.586% size of original (original: 21027 chars, delta: 3908 chars)
    cmdout	[Changelog] **Features**
    cmdout	[Changelog]   - Model ServicesDescription has a new parameter system_data
    cmdout	[Changelog]   - Model ServicesProperties has a new parameter acr_configuration
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from a501906. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️healthcareapis/mgmt/2020-03-30/healthcareapis [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️healthcareapis/mgmt/2020-03-15/healthcareapis [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️healthcareapis/mgmt/2019-09-16/healthcareapis [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/healthcareapis/mgmt/2018-08-20-preview/healthcareapis [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from a501906. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] 2021-01-20 06:02:31 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-healthcareapis"
    cmderr	[generate.py] 2021-01-20 06:02:31 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
    cmderr	[generate.py] 2021-01-20 06:02:31 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/healthcareapis/azure-resourcemanager-healthcareapis --java.namespace=com.azure.resourcemanager.healthcareapis   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md
    cmderr	[generate.py] 2021-01-20 06:03:11 INFO [CI][Success] Write to ci.yml
    cmderr	[generate.py] 2021-01-20 06:03:11 INFO [POM][Process] dealing with pom.xml
    cmderr	[generate.py] 2021-01-20 06:03:11 INFO [POM][Skip] pom already has module azure-resourcemanager-healthcareapis
    cmderr	[generate.py] 2021-01-20 06:03:11 INFO [POM][Success] Write to pom.xml
    cmderr	[generate.py] 2021-01-20 06:03:11 INFO [POM][Process] dealing with root pom
    cmderr	[generate.py] 2021-01-20 06:03:11 INFO [POM][Success] Write to root pom
    cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
    cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
    cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
    cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
    cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
  • ️✔️azure-resourcemanager-healthcareapis [View full logs]  [Release SDK Changes]
    cmderr	[Inst] 2021-01-20 06:05:52 DEBUG Got artifact_id: azure-resourcemanager-healthcareapis
    cmderr	[Inst] 2021-01-20 06:05:52 DEBUG Got artifact: pom.xml
    cmderr	[Inst] 2021-01-20 06:05:52 DEBUG Got artifact: azure-resourcemanager-healthcareapis-1.0.0-beta.1-sources.jar
    cmderr	[Inst] 2021-01-20 06:05:52 DEBUG Got artifact: azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar
    cmderr	[Inst] 2021-01-20 06:05:52 DEBUG Match jar package: azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar
    cmderr	[Inst] 2021-01-20 06:05:52 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12125/azure-sdk-for-java/azure-resourcemanager-healthcareapis/azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar\" -o azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-healthcareapis -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-healthcareapis-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
    ```"}
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from a501906. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.HealthcareApis [View full logs]  [Release SDK Changes]
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from a501906. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/healthcareapis/resource-manager/readme.md
  • ️✔️healthcareapis [View full logs]  [Release Schema Changes]
    cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager] WARN [email protected] No repository field.
    cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@moria97
Copy link
Contributor Author

moria97 commented Dec 15, 2020

@moria97 moria97 added DoNotMerge <valid label in PR review process> use to hold merge after approval ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Dec 15, 2020
@moria97 moria97 requested a review from leni-msft December 17, 2020 05:40
@moria97 moria97 requested a review from leni-msft December 17, 2020 14:03
@leni-msft leni-msft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Dec 18, 2020
@ghost
Copy link

ghost commented Jan 3, 2021

Hi, @moria97. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
…rsion stable/2021-01-11 (Azure#12125)

* Adds base for updating Microsoft.HealthcareApis from version stable/2020-03-30 to version 2021-01-11

* Updates readme

* Updates API version in new specs and examples

* Add new api spec

* Fix tests.

* Add description for systemData

* Remove common type change

* Prettier spec

* Change definition name

* Modify list result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants