-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2021-01-11 #12125
Merged
leni-msft
merged 10 commits into
Azure:master
from
moria97:dev-healthcareapis-Microsoft.HealthcareApis-2021-01-11
Jan 20, 2021
Merged
[Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2021-01-11 #12125
leni-msft
merged 10 commits into
Azure:master
from
moria97:dev-healthcareapis-Microsoft.HealthcareApis-2021-01-11
Jan 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Generation Artifacts
|
This was referenced Dec 15, 2020
This was referenced Dec 15, 2020
moria97
added
DoNotMerge
<valid label in PR review process> use to hold merge after approval
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
labels
Dec 15, 2020
leni-msft
suggested changes
Dec 17, 2020
specification/common-types/resource-management/v1/privatelinks.json
Outdated
Show resolved
Hide resolved
leni-msft
suggested changes
Dec 17, 2020
specification/common-types/resource-management/v1/privatelinks.json
Outdated
Show resolved
Hide resolved
leni-msft
added
the
Approved-OkToMerge
<valid label in PR review process>add this label when assignee approve to merge the updates
label
Dec 18, 2020
leni-msft
approved these changes
Dec 18, 2020
Hi, @moria97. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
no-recent-activity
label
Jan 3, 2021
moria97
removed
the
DoNotMerge
<valid label in PR review process> use to hold merge after approval
label
Jan 20, 2021
ghost
removed
the
no-recent-activity
label
Jan 20, 2021
This was referenced Jan 20, 2021
Closed
11 tasks
m-nash
reviewed
Mar 17, 2021
...lthcareapis/resource-manager/Microsoft.HealthcareApis/stable/2021-01-11/healthcare-apis.json
Show resolved
Hide resolved
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…rsion stable/2021-01-11 (Azure#12125) * Adds base for updating Microsoft.HealthcareApis from version stable/2020-03-30 to version 2021-01-11 * Updates readme * Updates API version in new specs and examples * Add new api spec * Fix tests. * Add description for systemData * Remove common type change * Prettier spec * Change definition name * Modify list result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-OkToMerge
<valid label in PR review process>add this label when assignee approve to merge the updates
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.