[Identity] Added default console output for DeviceCodeCredential #15266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaabs
requested review from
AlexanderSher,
KrzysztofCwalina and
tg-msft
as code owners
ghost
added
the
| @@ -76,7 +87,7 @@ internal DeviceCodeCredential(Func<DeviceCodeInfo, CancellationToken, Task> devi | |||
|
|
|||
| internal DeviceCodeCredential(Func<DeviceCodeInfo, CancellationToken, Task> deviceCodeCallback, string tenantId, string clientId, TokenCredentialOptions options, CredentialPipeline pipeline, MsalPublicClient client) | |||
| { | |||
| _clientId = clientId ?? throw new ArgumentNullException(nameof(clientId)); | |||
| _clientId = clientId ?? Constants.DeveloperSignOnClientId; | |||
| @@ -95,6 +96,41 @@ public async Task AuthenticateWithDeviceCodeMockAsync2() | |||
| Assert.AreEqual(token.Token, expectedToken); | |||
| } | |||
|
|
|||
| [Test] | |||
There was a problem hiding this comment.
Should we make this test [NonParallelizable]?
AlexanderSher
approved these changes
Sep 18, 2020
g2vinay
approved these changes
Sep 18, 2020
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for printing device code message to console when no
deviceCodeCallbackis specified.Fixes #13689