Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Use Console" Option to DeviceCodeCredential #10229

Closed
joshfree opened this issue Jul 23, 2020 · 2 comments · Fixed by #11355
Closed

Add "Use Console" Option to DeviceCodeCredential #10229

joshfree opened this issue Jul 23, 2020 · 2 comments · Fixed by #11355
Assignees
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.

Comments

@joshfree
Copy link
Member

Investigate adding a "Use Console" option for Device Code Credential

@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jul 23, 2020
@joshfree joshfree added this to the [2020] October milestone Jul 23, 2020
@joshfree joshfree added the blocking-release Blocks release label Sep 8, 2020
@ramya-rao-a
Copy link
Contributor

@jonathandturner Can you add details as to what exactly is required here?

@sadasant
Copy link
Contributor

Here's from Vinay:

Functionality/Feature Request:
We need to add the functionality which provides user the ability to indicate that Device Code Credential should send/print the device code info details to the console.
All the languages should've an issue around this in their October Milestone for Identity.

Approach:
So, to achieve this, the approach which we are going to take is to print the device code details to console as the default behavior. It will be overridden by the user if they configure their custom callback during Device Code Credential construction.

Next Steps:
Currently, callback is a required parameter for Device Code Credential.
We need to make it optional and default the callback to print to console.
Java PR for reference: Azure/azure-sdk-for-java#15332

From Scott Schaab:

Here's the PR for the change in .NET Azure/azure-sdk-for-net#15266

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants