Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnvVar AuthorityHost #10780

Merged
merged 8 commits into from
Apr 6, 2020
Merged

Add EnvVar AuthorityHost #10780

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2a87ba8
add environment variable Authority Host
XuGuang-Yao Mar 20, 2020
e9e1b0e
remove space
XuGuang-Yao Mar 20, 2020
f4aac73
remove redundant code
XuGuang-Yao Mar 23, 2020
26b9731
remove space
XuGuang-Yao Mar 23, 2020
e1b6ee2
read environment variable using get accessor
XuGuang-Yao Mar 26, 2020
f78b7d3
add tests of environment authority host.
XuGuang-Yao Apr 3, 2020
9df1400
use meaningful variable name
XuGuang-Yao Apr 3, 2020
9a80ef9
Add the [NonParallelizable] attribute to tests which update environme…
XuGuang-Yao Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/identity/Azure.Identity/src/EnvironmentVariables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ internal class EnvironmentVariables

public static string ProgramFilesX86 => Environment.GetEnvironmentVariable("ProgramFiles(x86)");
public static string ProgramFiles => Environment.GetEnvironmentVariable("ProgramFiles");
public static string AuthorityHost => Environment.GetEnvironmentVariable("AZURE_AUTHORITY_HOST");
}
}
3 changes: 2 additions & 1 deletion sdk/identity/Azure.Identity/src/TokenCredentialOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ public class TokenCredentialOptions : ClientOptions
/// </summary>
public TokenCredentialOptions()
{
AuthorityHost = KnownAuthorityHosts.AzureCloud;
Uri authorityHostUri = string.IsNullOrEmpty(EnvironmentVariables.AuthorityHost) ? KnownAuthorityHosts.AzureCloud : new Uri(EnvironmentVariables.AuthorityHost);
tzhanl marked this conversation as resolved.
Show resolved Hide resolved
AuthorityHost = authorityHostUri;
}
}
}