Add EnvVar AuthorityHost #10780
Merged
Add EnvVar AuthorityHost #10780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaabs
approved these changes
Mar 25, 2020
ellismg
reviewed
Mar 25, 2020
schaabs
requested changes
Mar 25, 2020
There was a problem hiding this comment.
@XuGuang-Yao could you make the change to read the environment variable in the AuthorityHost property get accessor only when the property hasn't been set as suggested above?
schaabs
approved these changes
Mar 27, 2020
|
Can you add tests please? |
schaabs
reviewed
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EnvVar AuthorityHost to EnvironmentVariables.cs.
TokenCredentialOptions has an AuthorityHost property.
This will be modified to support EnvVar override with EnvironmentVariables.AuthorityHost.
Azure/azure-sdk-for-java/issues/5967