[service-bus] (non-sessions) Modify receive algorithm to match .NET. #9968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version works like this: receive(maxMessages, maxWaitTime) Internally we then wait for: 1. maxMessages to arrive 2. maxWaitTime to expire or 3. An internal 1 second timeout that will fire _after_ the first message has been received.
…ols exit from receiveMessages
richardpark-msft
requested review from
chradek,
HarshaNalluru and
ramya-rao-a
as code owners
ghost
added
the
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chradek
reviewed
Jul 8, 2020
sdk/servicebus/service-bus/test/internal/batchingReceiver.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Harsha Nalluru <[email protected]>
…at mode and not all the messages appear to be recieved
…est timeout between "remaining time for receive" vs "maxTimeAfterFirstMessageInMs"
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… to note that it only controls the time to receive the first message.
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I needed to add an actual implementation for the EventEmitter (I use it in the tests). Just re-running, no code changes. |
ramya-rao-a
approved these changes
Jul 16, 2020
richardpark-msft
added a commit
that referenced
this pull request
Jul 17, 2020
…sages algorithm (#10107) [sessions] Changing our receiveMessages() algorithm to match .NET's. The new version works like this: receive(maxMessages, maxWaitTime) Internally we then wait for: maxMessages to arrive maxWaitTime to expire or An internal 1 second timeout that will fire after the first message has been received or the remaining time left from maxWaitTime (whichever one is smaller) (also eliminated some dead code as a result of making SessionManager a sample rather than being part of the core library) Complements #9968 and is the final change for #9718
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing our receiveMessages() algorithm to match .NET's.
The new version works like this:
receive(maxMessages, maxWaitTime)
Internally we then wait for:
or
has been received.
TODO:
Partial fix for #9718