[service-bus] Change MessageSession over to using the .NET receiveMessages algorithm #10107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r (should just be an equivalent call, just tucked into a function)
- Made what _should_ be a harmless change - moved addCreditAndSetTimer _above_ the registration of the event handlers, making it more like the batchingreceiver. It also just gives me a simple signal to say "hey, everything is registered now". Also able to do some nice code deletions: - Removed the old "message wait" timer that wasn't getting used anywhere but receiveMessages - Removed sessionCallee - we don't have a session manager anymore anyways so it's useless (ie, it's always "standalone") - newMessageWaitTimeoutInMs is only used locally in the promise. Demoted to be a local variable instead. - Like in the non-session MessageReceiver I killed the `resetTimerOnNewMessageReceived` functions for streaming - the timeout value was never set so it was essentially a no-op.
… BatchingReceiver tests except `setupFakeReceiver` doesn't add the .session EventEmitter to the mock receiver - not used by MessageSession.
…-session cases in tests with just a little bit more code to simulate drain.
richardpark-msft
requested review from
chradek,
HarshaNalluru and
ramya-rao-a
as code owners
ghost
added
the
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
reviewed
Jul 17, 2020
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
approved these changes
Jul 17, 2020
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sessions] Changing our receiveMessages() algorithm to match .NET's.
The new version works like this:
receive(maxMessages, maxWaitTime)
Internally we then wait for:
or
has been received or the remaining time left from
maxWaitTime(whichever oneis smaller)
Complements #9968 and is the final change for #9718