Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Support for Development Connection String - storage-blob #5235

Merged
merged 3 commits into from
Sep 25, 2019
Merged

[Storage] Support for Development Connection String - storage-blob #5235

merged 3 commits into from
Sep 25, 2019

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Sep 24, 2019 •
edited
Loading

This PR adds the support for Development connection string and some tests for the emulator(local).

  • Development Connection String
    • DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://127.0.0.1:10000/devstoreaccount1;
  • Shorthand notation is also supported
    • UseDevelopmentStorage=true or
    • UseDevelopmentStorage=true;DevelopmentStorageProxyUri=http://myProxyUri

Added a separate set of Emulator tests(test suite in the node tests) which will be skipped if the STORAGE_CONNECTION_STRING environment variable doesn't start with UseDevelopmentStorage=true.

@HarshaNalluru HarshaNalluru self-assigned this Sep 24, 2019
@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Sep 24, 2019
@HarshaNalluru
Copy link
Member Author

/azp run js - storage-blob - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jeremymeng
jeremymeng approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

XiaoningLiu
XiaoningLiu approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the new added tests be coverred by live test? Or anyone won't run these tests anymore?

XiaoningLiu
XiaoningLiu reviewed Sep 25, 2019
View reviewed changes
Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the new added tests be coverred by live test? Or anyone won't run these tests anymore?

@HarshaNalluru
Copy link
Member Author

HarshaNalluru commented Sep 25, 2019 •
edited
Loading

Will the new added tests be coverred by live test? Or anyone won't run these tests anymore?

Answered here - #5004 (comment)

@HarshaNalluru HarshaNalluru merged commit 38058f1 into Azure:feature/storage Sep 25, 2019
This was referenced Sep 26, 2019
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoningLiu XiaoningLiu XiaoningLiu approved these changes

@jeremymeng jeremymeng jeremymeng approved these changes

@jiacfan jiacfan Awaiting requested review from jiacfan

@vinjiang vinjiang Awaiting requested review from vinjiang

Assignees

@HarshaNalluru HarshaNalluru

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarshaNalluru @XiaoningLiu @jeremymeng