-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update nock from 10.0.6 to 11.3.2 #4992
Conversation
From the
If all the unit tests (playback mode) pass, we should try to update recordings for at least one library as well to ensure the recording side of CC: @HarshaNalluru |
cc @sadasant and @jonathandturner |
@@ -116,7 +116,7 @@ | |||
"mocha-junit-reporter": "^1.18.0", | |||
"mocha-multi": "^1.1.3", | |||
"nise": "^1.4.10", | |||
"nock": "^10.0.6", | |||
"nock": "^11.3.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadasant
@azure/test-utils-recorder
is imported by keyvault-secrets, right ?
Why is keyvault-secrets still depending on nock
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to change this, please do it in a separate PR (either before or after this PR is merged)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we don't need nock here. I most certainly just forgot to remove it. Can we remove it as part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still rather do this in a separate PR. I want to keep the version update PRs pure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Here's an issue: #5003
Tested the recording |
No description provided.