Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] Remove nise and nock as a dependency #5003

Closed
sadasant opened this issue Sep 5, 2019 · 0 comments · Fixed by #5075
Closed

[KeyVault] Remove nise and nock as a dependency #5003

sadasant opened this issue Sep 5, 2019 · 0 comments · Fixed by #5075
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@sadasant
Copy link
Contributor

sadasant commented Sep 5, 2019

They shouldn't be needed since we're using the common recorder!
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Sep 5, 2019
@sadasant sadasant self-assigned this Sep 5, 2019
@sadasant sadasant mentioned this issue Sep 5, 2019
Merged
sadasant added a commit to sadasant/azure-sdk-for-js that referenced this issue Sep 9, 2019
@sadasant
4.0.0-preview 5 and fixed Azure#5003
a8ce9c5 
Fixes Azure#5003
@sadasant sadasant mentioned this issue Sep 9, 2019
Merged
sadasant added a commit that referenced this issue Sep 9, 2019
@sadasant
4.0.0-preview 5 and fixed #5003 (#5075)
2455d46 
* 4.0.0-preview 5 and fixed #5003

Fixes #5003
* updated the versions everywhere they needed to be updated
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4.0.0-preview 5 and fixed #5003 sadasant/azure-sdk-for-js
1 participant
@sadasant