Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] [core-amqp] Update rhea-promise dependency versions #4399

Merged
merged 16 commits into from
Jul 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions common/config/rush/common-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
* instead of the latest version.
*/
// "some-library": "1.2.3"
// This is required to allow for backward compatibility with Service Bus Track 1
// TODO: Remove this once Service Bus is updated to use current depenedencies as part of Track 2
"rhea-promise": "^0.1.15"
},
/**
* The "rush check" command can be used to enforce that every project in the repo must specify
Expand All @@ -28,15 +31,16 @@
* This design avoids unnecessary churn in this file.
*/
"allowedAlternativeVersions": {
"@azure/ms-rest-js": [
"^2.0.0"
]
/**
* For example, allow some projects to use an older TypeScript compiler
* (in addition to whatever "usual" version is being used by other projects in the repo):
*/
// "typescript": [
// "~2.4.0"
// ]
"@azure/ms-rest-js": ["^2.0.0"],
// Following is required to allow for backward compatibility with Service Bus Track 1
// TODO: Remove this once Service Bus is updated to use current depenedencies as part of Track 2
"rhea-promise": ["^0.1.15"]
mikeharder marked this conversation as resolved.
Show resolved Hide resolved
}
}
58 changes: 33 additions & 25 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions sdk/core/core-amqp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"util": "^0.11.1"
},
"peerDependencies": {
"rhea-promise": "^0.1.15"
"rhea-promise": "^1.0.0"
},
"devDependencies": {
"@azure/identity": "1.0.0-preview.2",
Expand Down Expand Up @@ -104,7 +104,7 @@
"prettier": "^1.16.4",
"puppeteer": "^1.11.0",
"rhea": "^1.0.4",
"rhea-promise": "^0.1.15",
"rhea-promise": "^1.0.0",
"rimraf": "^2.6.2",
"rollup": "^1.16.3",
"rollup-plugin-commonjs": "^10.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/event-hubs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"debug": "^3.1.0",
"is-buffer": "^2.0.3",
"jssha": "^2.3.1",
"rhea-promise": "^0.1.15",
"rhea-promise": "^1.0.0",
"tslib": "^1.9.3",
"uuid": "^3.3.2"
},
Expand Down