-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Event Hubs] [core-amqp] Update rhea-promise dependency versions #4399
Conversation
sdk/core/core-amqp/package.json
Outdated
@@ -69,7 +69,7 @@ | |||
"util": "^0.11.1" | |||
}, | |||
"peerDependencies": { | |||
"rhea-promise": "^0.1.15" | |||
"rhea-promise": "^1.0.0" | |||
}, | |||
"devDependencies": { | |||
"@azure/identity": "^1.0.0-preview.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your branch onto current master. This dev dependency should be 1.0.0-preview.2
.
@mikeharder Looks like the build is still failing due to the peer dependency not installed issue. As in,
Did we have a work around for it yet? |
@ramya0820: While we have a solution for different dependency versions (updating versions in master immediately after shipping, we still need to find a solution for different peer dependencies. I will try to create a minimal repro, investigate workarounds, and potentially report the issue to rush and/or pnpm if I believe it's a bug. |
@ramya0820: You will probably need to rebase on |
- Accidentally added in Azure#4399
For more context, refer to #4228