Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade node version for unit tests #29243

Merged
merged 2 commits into from
Apr 9, 2024
Merged

downgrade node version for unit tests #29243

merged 2 commits into from
Apr 9, 2024

Conversation

ckairen
Copy link
Member

@ckairen ckairen commented Apr 9, 2024

closes #29244

@ckairen ckairen added the Central-EngSys This issue is owned by the Engineering System team. label Apr 9, 2024
@ckairen ckairen self-assigned this Apr 9, 2024
Copy link
Member

@KarishmaGhiya KarishmaGhiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@KarishmaGhiya KarishmaGhiya marked this pull request as ready for review April 9, 2024 22:33
@weshaggard
Copy link
Member

Can you reference an issue with more context why we need to pin this version?

@ckairen ckairen enabled auto-merge (squash) April 9, 2024 23:15
@ckairen ckairen merged commit 4a97846 into Azure:main Apr 9, 2024
16 checks passed
HarshaNalluru pushed a commit to HarshaNalluru/azure-sdk-for-js that referenced this pull request Apr 10, 2024
HarshaNalluru added a commit to HarshaNalluru/azure-sdk-for-js that referenced this pull request Apr 10, 2024
@ckairen ckairen deleted the al/pnpm branch November 21, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Reinstall Native Dependency step failure
4 participants