Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event hubs] Update OTEL to latest spec #25597

Merged
merged 7 commits into from
Apr 20, 2023
Merged

[event hubs] Update OTEL to latest spec #25597

merged 7 commits into from
Apr 20, 2023

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/event-hubs

Issues associated with this PR

Describe the problem that is addressed by this PR

Updating to latest OTEL messaging standards. This is also explained in a gist from @lmolkova here

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpodwysocki mpodwysocki requested a review from deyaaeldeen April 20, 2023 00:17
@mpodwysocki mpodwysocki enabled auto-merge (squash) April 20, 2023 00:21
@mpodwysocki mpodwysocki merged commit 190524c into main Apr 20, 2023
@mpodwysocki mpodwysocki deleted the feat/eventhubs-otel branch April 20, 2023 18:11
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Sep 20, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-08-01 (Azure#25633)

* Adds base for updating Microsoft.ContainerService/aks from version stable/2023-07-01 to version 2023-08-01

* Updates readme

* Updates API version in new specs and examples

* update (Azure#25468)

* Adding Azure Service Mesh and related changes. (Azure#25482)

* Adding Azure Service Mesh and related changes.

* Fix a typo with api version in examples

* fix a bug with egressGayeways for Istio

* add resourceuid field to managed cluster properties (Azure#25478)

* Adding examples for AzureServiceMesh (Azure#25535)

* Adding an example for AzureServiceMesh

* remove unneeded adonprofiles object

* Adding ingressGateway to the ASM example.

* Adding egressGateways to IstioComponents

* Add egressGateways to the request payload.

* Add BYO CA object to ServiceMeshProfile example

* Fix resource id format for Azure keyvault

* Enrich ASM examples (Azure#25597)

* add asm- prefix to upgrades field on mesh ops (Azure#25601)

---------

Co-authored-by: deveshdama <[email protected]>
Co-authored-by: daru__ <[email protected]>
Co-authored-by: Sanya Kochhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants