-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[event hubs] Update OTEL to latest spec #25597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
jeremymeng,
deyaaeldeen and
HarshaNalluru
as code owners
April 19, 2023 23:27
lmolkova
reviewed
Apr 19, 2023
API change check API changes are not detected in this pull request. |
lmolkova
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
deyaaeldeen
reviewed
Apr 20, 2023
deyaaeldeen
reviewed
Apr 20, 2023
deyaaeldeen
approved these changes
Apr 20, 2023
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Sep 20, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-08-01 (Azure#25633) * Adds base for updating Microsoft.ContainerService/aks from version stable/2023-07-01 to version 2023-08-01 * Updates readme * Updates API version in new specs and examples * update (Azure#25468) * Adding Azure Service Mesh and related changes. (Azure#25482) * Adding Azure Service Mesh and related changes. * Fix a typo with api version in examples * fix a bug with egressGayeways for Istio * add resourceuid field to managed cluster properties (Azure#25478) * Adding examples for AzureServiceMesh (Azure#25535) * Adding an example for AzureServiceMesh * remove unneeded adonprofiles object * Adding ingressGateway to the ASM example. * Adding egressGateways to IstioComponents * Add egressGateways to the request payload. * Add BYO CA object to ServiceMeshProfile example * Fix resource id format for Azure keyvault * Enrich ASM examples (Azure#25597) * add asm- prefix to upgrades field on mesh ops (Azure#25601) --------- Co-authored-by: deveshdama <[email protected]> Co-authored-by: daru__ <[email protected]> Co-authored-by: Sanya Kochhar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Updating to latest OTEL messaging standards. This is also explained in a gist from @lmolkova here
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists