Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service bus] Updating to latest OTEL for Messaging #25492

Merged
merged 8 commits into from
Apr 19, 2023

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/service-bus

Issues associated with this PR

Describe the problem that is addressed by this PR

Updating to latest OTEL messaging standards. This is also explained in a gist from @lmolkova here

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the Service Bus label Apr 7, 2023
@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 7, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-service-bus

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpodwysocki mpodwysocki marked this pull request as ready for review April 18, 2023 00:03
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding OTEL support! I think we need some changes to be consistent with .NET.

@mpodwysocki mpodwysocki requested a review from jeremymeng April 18, 2023 23:22
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@mpodwysocki mpodwysocki enabled auto-merge (squash) April 19, 2023 00:00
@mpodwysocki mpodwysocki merged commit 0b08a4f into main Apr 19, 2023
@mpodwysocki mpodwysocki deleted the feat/sb-otel-tracing branch April 19, 2023 00:27
mpodwysocki added a commit that referenced this pull request Apr 20, 2023
### Packages impacted by this PR

- @Azure/event-hubs

### Issues associated with this PR


### Describe the problem that is addressed by this PR

Updating to latest [OTEL messaging
standards](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md#messaging-attributes).
This is also explained in a gist from @lmolkova
[here](https://gist.github.com/lmolkova/e4215c0f44a49ef824983382762e6b92)

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_

- #25492

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Sep 28, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-08-02-preview (Azure#25891)

* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-07-02-preview to version 2023-08-02-preview

* Updates readme

* Updates API version in new specs and examples

* update (Azure#25469)

* Fix the IstioComponents structure (Azure#25492)

* add netorkPolicy "none" (Azure#25511)

* add netorkPolicy "none" value and description

* add "none" enum value to networkPolicy

* add addon autoscaling api (Azure#25479)

* Update trusted access put and delete to async operation (Azure#25537)

* Update trusted access put and delete to async operation

* Update example

* Update header

* Swagger changes for adding autoscalerprofile flags for daemonset/multipleexpander (Azure#25487)

* Adding json changes

* adding "daemonsets" to the custom-words

* Editing "Expander" to "expander"

* Removing daemonset custom word from this pr. look at: Azure/azure-rest-api-specs#25533

* Add AzureServiceMesh example (Azure#25560)

* Add AzureServiceMesh example

* Fix AKV resource id format

* enrich ASM examples (Azure#25598)

---------

Co-authored-by: deveshdama <[email protected]>
Co-authored-by: robogatikov <[email protected]>
Co-authored-by: Chih-Sheng Huang <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Youn Jae Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants