identity: managedIdentityCredential expires-in/-on #24102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes token lifetimes are tracked by absolute timestamps ("expires
On") and sometimes using a time interval ("expires In"). The
managedIdentityCredential AppTokenProvider implementation was
inconsistent in its treatment, directly coercing an absolute timestamp
to an interval.
See #24003 for
example downstream effects.
nwf-msr
requested review from
KarishmaGhiya,
witemple-msft and
schaabs
as code owners
ghost
added
Azure.Identity
customer-reported
|
Thank you for your contribution nwf-msr! We will review the pull request and get back to you soon. |
6 tasks
|
Can you run |
xirzec
reviewed
Dec 5, 2022
sdk/identity/identity/src/credentials/managedIdentityCredential/index.ts
Outdated
Show resolved
Hide resolved
xirzec
reviewed
Dec 5, 2022
sdk/identity/identity/src/credentials/managedIdentityCredential/index.ts
Outdated
Show resolved
Hide resolved
…l/index.ts Co-authored-by: Jeff Fisher <[email protected]>
…l/index.ts Co-authored-by: Jeff Fisher <[email protected]>
|
Thanks for the feedback; JS is not my native tongue. :) Would you like me to squash the commits or will you do that when merging? |
I'll do it when merging |
KarishmaGhiya
approved these changes
Dec 5, 2022
KarishmaGhiya
pushed a commit
that referenced
this pull request
Dec 6, 2022
KarishmaGhiya
pushed a commit
that referenced
this pull request
Dec 6, 2022
Thanks again for your contribution! 😄 |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Nov 10, 2023
Release web 2023 01 01 (Azure#26545) * Add new api-version 2023-01-01 (Azure#22962) * Add new api-version 2023-01-01 * Change default package api-version * Updated workflowstate to be a reference (Azure#23084) * Fix OneDeploy request and response bodies (Azure#23224) * Fix OneDeploy request and response bodies * Fixing typo * Add Container Apps Environment Id in checknameavailability API (Azure#24102) Co-authored-by: Vishal Gupta <[email protected]> * Add minTlsCipherSuite property (Azure#24198) * Add minTlsCipherSuite property * Move to SiteConfig --------- Co-authored-by: Chris Rosenblatt <[email protected]> * Dapr configuration for a site (Azure#24606) * Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail --------- Co-authored-by: Sushmitha Vangala <[email protected]> * Fix for JS SDK check failure for Dapr Config (Azure#25493) * Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail * JS Sdk check fail fix --------- Co-authored-by: Sushmitha Vangala <[email protected]> * Release web 2023 01 01 (Azure#25157) * Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a1110765d08c5c96d65f884237313515d842586. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments --------- Co-authored-by: Rohini Sharma <[email protected]> * Release web 2023 01 01 (Azure#25629) * Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a1110765d08c5c96d65f884237313515d842586. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments * Removing quota type parameter --------- Co-authored-by: Rohini Sharma <[email protected]> * Adding workload profile & resource config to Site (Azure#25868) * Adding workload profile & resource config to Site * prettier fix * cosmetic fix * updating examples * prettier fix * Fix Python SDK failure for Dapr log level config (Azure#26198) * Rename log level enum for dapr * Fix Python SDK failure for Dapr log level config * Rename log level num for dapr (Azure#26374) * Rename log level num for dapr * Rename log level num for dapr * initial change to add ase regions (Azure#26333) * initial change to add ase regions * addressing comments * nit adding example as suggested * formatting code * add custom word * prettier everything * prettier everything * Revert "Fix OneDeploy request and response bodies (Azure#23224)" (Azure#26580) This reverts commit 7dfc303ee18440ee5eede155bb0d63797fbdc4bb. --------- Co-authored-by: Alex Karcher <[email protected]> Co-authored-by: dannysongg <[email protected]> Co-authored-by: Vishal Gupta <[email protected]> Co-authored-by: Vishal Gupta <[email protected]> Co-authored-by: Chris Rosenblatt <[email protected]> Co-authored-by: Chris Rosenblatt <[email protected]> Co-authored-by: SushmithaVReddy <[email protected]> Co-authored-by: Sushmitha Vangala <[email protected]> Co-authored-by: rohinisharma <[email protected]> Co-authored-by: Rohini Sharma <[email protected]> Co-authored-by: mukundnigam <[email protected]> Co-authored-by: Kirstyn Amperiadis <[email protected]> Co-authored-by: Haochi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity
Issues associated with this PR
#24003
Describe the problem that is addressed by this PR
Sometimes token lifetimes are tracked by absolute timestamps ("expires On") and sometimes using a time interval ("expires In"). The managedIdentityCredential AppTokenProvider implementation was inconsistent in its treatment, directly coercing an absolute timestamp to an interval.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
It would be better if the SDK were consistent internally in its use of relative or absolute time, but that's a much taller ask.
Are there test cases added in this PR? (If not, why?)
No, but someone should.
Checklists