Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct provider IDs for @azure/arm-reservations QuotaGetRequest #26580

Closed
5 tasks
leawn opened this issue Jul 21, 2023 · 7 comments
Closed
5 tasks

Correct provider IDs for @azure/arm-reservations QuotaGetRequest #26580

leawn opened this issue Jul 21, 2023 · 7 comments
Assignees
Labels
Mgmt This issue is related to a management-plane library. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. Quota Quota Service Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@leawn
Copy link

leawn commented Jul 21, 2023

  • Package Name: @azure/arm-reservations
  • Package Version: "9.0.0"
  • Operating system: macOS Ventura 13.4.1
  • nodejs
    • version: "19.5.0"
  • typescript
    • version: "4.7.4"
  • Is the bug related to documentation in

Describe the bug
Using the following method of AzureReservationAPI from @azure/arm-reservations:
const azureReservationAPI = new AzureReservationAPI(new ClientSecretCredential(...), subscriptionId);
const quota = await azureReservationAPI.quota.get(subscriptionId, 'Microsoft.Network', 'eastus', 'loadBalancers')

Returns back an error message:
The value provided for one of the Provider Ids was not in the correct format. Verify the value of Provider ID : Microsoft.Network'.

When using a different provider ID such as Microsoft.Compute it returns a successful response, but when using other provider IDs such as Microsoft.Network or Microsoft.Storage gives back the same error message.

To Reproduce
Steps to reproduce the behavior:

  1. Install @azure/arm-reservations & @azure/identity
  2. Configure a ClientSecretCredential()
  3. Configure a AzureReservationAPI()
  4. Make a AzureReservationAPI().quota.get() request with a provider ID other that Microsoft.Compute

Expected behavior
a AzureReservationAPI().quota.get() request with provider IDs such as Microsoft.Network & Microsoft.Storage return a successful response (which corresponds to QuotaGetResponse interface)

@jeremymeng jeremymeng added the Mgmt This issue is related to a management-plane library. label Jul 24, 2023
@otfavoured
Copy link

otfavoured commented Jul 27, 2023

Hello @qiaozha , Do we have update on this query issue. Thank you.

@kazrael2119
Copy link
Contributor

Hello @qiaozha , Do we have update on this query issue. Thank you.

I'll take a look at this issue

@kazrael2119
Copy link
Contributor

@leawn @otfavoured ,I can repro your your issue. After my check, I think that quota in @azure/arm-reservations only support Microsoft.Compute and Microsoft.MachineLearningServiceshttps://github.com/Azure/azure-rest-api-specs/blob/main/specification/reservations/resource-manager/Microsoft.Capacity/stable/2020-10-25/quota.json#L42

@qiaozha qiaozha added Service Attention Workflow: This issue is responsible by Azure service team. Quota Quota Service labels Jul 27, 2023
@leawn
Copy link
Author

leawn commented Jul 27, 2023

@kazrael2119 Is there a way to contribute to make other resource providers (such as Microsoft.Network) also supported?

@kazrael2119
Copy link
Contributor

kazrael2119 commented Jul 31, 2023

@qiaozha qiaozha added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Hi @leawn. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@github-actions
Copy link

Hi @leawn, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Aug 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2023
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Nov 10, 2023
Release web 2023 01 01 (Azure#26545)

* Add new api-version 2023-01-01 (Azure#22962)

* Add new api-version 2023-01-01

* Change default package api-version

* Updated workflowstate to be a reference (Azure#23084)

* Fix OneDeploy request and response bodies (Azure#23224)

* Fix OneDeploy request and response bodies

* Fixing typo

* Add Container Apps Environment Id in checknameavailability API (Azure#24102)

Co-authored-by: Vishal Gupta <[email protected]>

* Add minTlsCipherSuite property (Azure#24198)

* Add minTlsCipherSuite property

* Move to SiteConfig

---------

Co-authored-by: Chris Rosenblatt <[email protected]>

* Dapr configuration for a site (Azure#24606)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

---------

Co-authored-by: Sushmitha Vangala <[email protected]>

* Fix for JS SDK check failure for Dapr Config (Azure#25493)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

* JS Sdk check fail fix

---------

Co-authored-by: Sushmitha Vangala <[email protected]>

* Release web 2023 01 01 (Azure#25157)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a1110765d08c5c96d65f884237313515d842586.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

---------

Co-authored-by: Rohini Sharma <[email protected]>

* Release web 2023 01 01 (Azure#25629)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a1110765d08c5c96d65f884237313515d842586.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

* Removing quota type parameter

---------

Co-authored-by: Rohini Sharma <[email protected]>

* Adding workload profile & resource config to Site (Azure#25868)

* Adding workload profile & resource config to Site

* prettier fix

* cosmetic fix

* updating examples

* prettier fix

* Fix Python SDK failure for Dapr log level config (Azure#26198)

* Rename log level enum for dapr

* Fix Python SDK failure for Dapr log level config

* Rename log level num for dapr (Azure#26374)

* Rename log level num for dapr

* Rename log level num for dapr

* initial change to add ase regions (Azure#26333)

* initial change to add ase regions

* addressing comments

* nit adding example as suggested

* formatting code

* add custom word

* prettier everything

* prettier everything

* Revert "Fix OneDeploy request and response bodies (Azure#23224)" (Azure#26580)

This reverts commit 7dfc303ee18440ee5eede155bb0d63797fbdc4bb.

---------

Co-authored-by: Alex Karcher <[email protected]>
Co-authored-by: dannysongg <[email protected]>
Co-authored-by: Vishal Gupta <[email protected]>
Co-authored-by: Vishal Gupta <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: SushmithaVReddy <[email protected]>
Co-authored-by: Sushmitha Vangala <[email protected]>
Co-authored-by: rohinisharma <[email protected]>
Co-authored-by: Rohini Sharma <[email protected]>
Co-authored-by: mukundnigam <[email protected]>
Co-authored-by: Kirstyn Amperiadis <[email protected]>
Co-authored-by: Haochi <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mgmt This issue is related to a management-plane library. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. Quota Quota Service Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

5 participants