[identity] Fix MSAL Flow additionallyAllowedTenantIds to pass through #23704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
KarishmaGhiya,
witemple-msft and
schaabs
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
| @@ -29,7 +29,7 @@ describe("OnBehalfOfCredential", function () { | |||
| userAssertionToken: "user-assertion", | |||
| }); | |||
|
|
|||
| const newMSALClientLogs = () => | |||
| const newMSALClientLogs = (): number => | |||
There was a problem hiding this comment.
This is just for clarity right? was it causing some issue? curious to know @mpodwysocki
There was a problem hiding this comment.
maybe a lint thing, it's common to enforce explicitly declaring return types to avoid accidentally returning the wrong thing
KarishmaGhiya
requested review from
mikeharder,
praveenkuttappan,
deyaaeldeen,
jeremymeng,
ckairen,
benbp,
weshaggard,
qiaozha,
dw511214992,
MaryGao,
bterlson,
xirzec,
joheredi,
petrsvihlik,
AikoBB,
maximrytych-ms,
guilhermeluizsp,
danielav7,
ajpeacock0,
nathpete-msft and
miguhern
as code owners
KarishmaGhiya
requested review from
witemple-msft and
schaabs
and removed request for
MaryGao,
HarshaNalluru,
schaabs,
zfengms,
joheredi,
danielav7,
AikoBB,
RoyHerrod,
nathpete-msft,
ronniegeraghty,
guilhermeluizsp,
ckairen,
dw511214992,
anilba06,
LuChen-Microsoft,
praveenkuttappan,
qiaozha,
whisper6284,
witemple-msft,
miguhern,
maximrytych-ms and
paterasMSFT
xirzec
approved these changes
Nov 4, 2022
| @@ -29,7 +29,7 @@ describe("OnBehalfOfCredential", function () { | |||
| userAssertionToken: "user-assertion", | |||
| }); | |||
|
|
|||
| const newMSALClientLogs = () => | |||
| const newMSALClientLogs = (): number => | |||
There was a problem hiding this comment.
maybe a lint thing, it's common to enforce explicitly declaring return types to avoid accidentally returning the wrong thing
|
We'll need the same changes for msalBrowserCommon |
KarishmaGhiya
pushed a commit
that referenced
this pull request
Nov 7, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
The
additionallyAllowedTenantIdswas not passed through to the baseMsalFlowclass to allow it to resolve the additionally allowed tenant IDs in thegetToken()method. This fixes this bug and also fixes some minor ESLint issues.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists