Multi-tenant authentication does not work with a client secret credentials

[vitalymelni]

• Package Name: @azure/identity
• Package Version: 3.0.0
• Operating system: macOS 12.6
• nodejs
  • version: v16.16.0
• typescript
  • version: 4.8.3
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug
Trying to authenticate with a tenant id that is different then the tenant id in the client secret, does not work, even when passing the options "additionallyAllowedTenants" correctly (with '*' or with both the tenant ids)

To Reproduce
Steps to reproduce the behavior:

1. Register an app in Azure AD and create a client secret credentials for it
2. Give permissions to the app to other tenant
3. Run the following code:

import { ClientSecretCredential } from '@azure/identity';
import { Client } from '@microsoft/microsoft-graph-client';
import { TokenCredentialAuthenticationProvider } from '@microsoft/microsoft-graph-client/authProviders/azureTokenCredentials';

const tokenCreds = new ClientSecretCredential(
  '<first-tenant-id>',
  '<client-id>',
  '<client-secret>',
  { additionallyAllowedTenants: ['*'] },
);

const authProvider = new TokenCredentialAuthenticationProvider(tokenCreds, {
  scopes: ['https://graph.microsoft.com/.default'],
  getTokenoptions: { tenantId: '<second-tenant-id>' },
});

const client = Client.initWithMiddleware({
  authProvider,
});

client.api('/organization').get().then((res) => console.log(res));

4. the code fails with the following error (on the last line):

The current credential is not configured to acquire tokens for tenant <first-tenant-id>. To enable acquiring tokens for this tenant add it to the AdditionallyAllowedTenants on the credential options, or add "*" to AdditionallyAllowedTenants to allow acquiring tokens for any tenant.

Expected behavior
The code should work

Additional context
The issue seems to be here:
https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/src/msal/nodeFlows/msalNodeCommon.ts#L306

It looks like this line does not take into account the "additionallyAllowedTenants" option and doesn't pass it to the "processMultiTenantRequest", which uses a default empty array:

azure-sdk-for-js/sdk/identity/identity/src/util/processMultiTenantRequest.ts

Line 19 in 0ea9f14

additionallyAllowedTenantIds: string[] = []

[mpodwysocki]

Fixed as per #23704 and #23734