[engsys][eslint-plugin] upgrade eslint dependencies #21733
Conversation
- eslint to ^8.0.0 - @types/eslint to ~8.4.0 - @typescript-eslint plugins to ~5.22.0 * Fix broken test because of class property node type changes. Improve test a bit to also verifying error line and column numbers * Disable @typescript-eslint/no-invalid-this After upgrading this rule reports more false positives. The following comment on the github issue suggests that it doesn't work for some callbacks because it is just a simple rule that doesn't do type analysis. typescript-eslint/typescript-eslint#3620 (comment) * Fix linter issues after upgrading the plugins in eslint-plugin-azure-sdk. Also upgrade eslint version in the impacted packages
jeremymeng
requested review from
praveenkuttappan,
witemple-msft,
deyaaeldeen,
mikeharder,
KarishmaGhiya,
maorleger,
HarshaNalluru,
xirzec,
joheredi and
sadasant
as code owners
ghost
added
Azure.Core
App Configuration
| @@ -17,7 +17,7 @@ function isDefined<T>(thing: T | undefined | null): thing is T { | |||
| * @param properties - The name of the properties that should appear in the object. | |||
| * @internal | |||
| */ | |||
| export function isObjectWithProperties<Thing extends unknown, PropertyName extends string>( | |||
| export function isObjectWithProperties<Thing, PropertyName extends string>( | |||
There was a problem hiding this comment.
opportunity for core-util
|
API change check for API changes are not detected in this pull request for |
|
API change check for API changes are not detected in this pull request for |
|
API change check for API changes are not detected in this pull request for |
|
API change check for API changes are not detected in this pull request for |
|
API change check for API changes are not detected in this pull request for |
|
API change check for API changes are not detected in this pull request for |
|
API change check for API changes are not detected in this pull request for |
I will log an issue to re-visit this rule in case it got improved in the future, or if we missed anything. |
jeremymeng
force-pushed
the
engsys/upgrade-eslint
branch
from
c10b8cd to
e63f32c
Compare
|
Bumping the rest of packages to use eslint@^8.0.0 works fine too. I will work with EngSys to merge directly to avoid triggering build storm. |
|
API change check API changes are not detected in this pull request. |
Fix broken test because of class property node type changes. Improve test a bit
to also verifying error line and column numbers
Disable @typescript-eslint/no-invalid-this
After upgrading this rule reports more false positives. The following comment on the
github issue suggests that it doesn't work for some callbacks because it is just
a simple rule that doesn't do type analysis.
typescript-eslint/typescript-eslint#3620 (comment)