Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency package eslint has a new version available #19219

Closed
azure-sdk opened this issue Dec 10, 2021 · 3 comments
Closed

Dependency package eslint has a new version available #19219

azure-sdk opened this issue Dec 10, 2021 · 3 comments
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required EngSys This issue is impacting the engineering system.

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 10, 2021 •
edited
Loading

We have identified a dependency on version 7.32.0 of eslint. A new version (8.15.0) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.

  2. Identify all packages that take a dependency on this package.

  3. Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

  4. Run rush update to ensure the new version is pulled in.

  5. Make relevant changes to absorb the breaking changes.

  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 10, 2021
@jeremymeng jeremymeng mentioned this issue Dec 13, 2021
Closed
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Dec 13, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 13, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Dec 14, 2021
Closed
@jeremymeng jeremymeng added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Dec 14, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Dec 15, 2021
Closed
@ramya-rao-a
Copy link
Contributor

For anyone considering taking up this task, please take up #19160 at the same time in the same PR

@ramya-rao-a
Copy link
Contributor

Code pointers:

  • Set up your dev environment
  • Run rush lint to run the linter across all the packages. This should succeed without any errors. If you see any errors, try to fix them first in a separate pull request and then continue here
  • Update the version of eslint and @types/eslint used in all the package.json files in this repo
  • Run rush update to ensure the new versions gets installed
  • Run rushx build in the eslint-plugin-azure-sdk package folder to find and fix any build errors in the plugin due to the upgrade.
  • Run rush lint to run the linter across all the packages. This should succeed without any errors. If you see any errors, include the fix for them in the same pull request that made the dependency upgrade

@azure-sdk azure-sdk removed help wanted This issue is tracking work for which community contributions would be welcomed and appreciated EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. eslint plugin labels Feb 7, 2022
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Mar 9, 2022
@azure-sdk azure-sdk removed the Client This issue points to a problem in the data-plane of the library. label Mar 14, 2022
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels May 4, 2022
@jeremymeng
Copy link
Member

upgrade to ^8.0.0 in PR #21733, and 83e13d8

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremymeng @ramya-rao-a @azure-sdk