[Batch] Fix missing SharedKeyCredentials export #19736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dpwatrous
force-pushed
the
dpwatrous/rollup-fix
branch
from
a8f8771 to
2564a93
Compare
dpwatrous
force-pushed
the
dpwatrous/rollup-fix
branch
from
a791617 to
e37d477
Compare
dpwatrous
force-pushed
the
dpwatrous/rollup-fix
branch
from
e37d477 to
bf69405
Compare
dpwatrous
force-pushed
the
dpwatrous/rollup-fix
branch
from
bf69405 to
31a3446
Compare
|
@deyaaeldeen just to give you some context, we were trying to update the Batch samples to the latest 10.0.2 SDK version and noticed that SharedKeyCredentials weren't in the rollup output. This PR should fix that, although it was a little more complex than I had originally thought due to the node.js-specific dependencies of SharedKeyCredentials |
deyaaeldeen
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Looks great!
I actually had to do some work for exposing this class before in #18469 but I forgot to update the entry point to point to the new index module.
|
Gotcha - I saw your other PR and figured it was something like that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup was using batchServiceClient.js as an entry point, which did not include the SharedKeyCredentials class. (See issue #18328). In the course of fixing that, changed some rollup configuration due to SharedKeyCredentials relying on commonjs modules and the built-in node.js buffer module.