Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@azure/batch has no exported member BatchSharedKeyCredentials #18328

Closed
3 of 6 tasks
mszczepanczyk opened this issue Oct 22, 2021 · 4 comments
Closed
3 of 6 tasks

@azure/batch has no exported member BatchSharedKeyCredentials #18328

mszczepanczyk opened this issue Oct 22, 2021 · 4 comments
Assignees
@deyaaeldeen
Labels
Batch Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@mszczepanczyk
Copy link

  • Package Name: @azure/batch
  • Package Version: 10.0.1
  • Operating system: macOS
  • nodejs
    • version: v16.10.0
  • browser
    • name/version:
  • typescript
    • version: 4.4.4
  • Is the bug related to documentation in

Describe the bug
BatchSharedKeyCredentials is not exported from @azure/batch.

To Reproduce

import { BatchSharedKeyCredentials } from '@azure/batch';

Compilation fails with Type error: Module '"@azure/batch"' has no exported member 'BatchSharedKeyCredentials'.

This import is also used in the first example in README.md under Authentication.

Expected behavior
It should compile. Version 8.0.0 works just fine.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 22, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 22, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 22, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 22, 2021
@logicabrity
Copy link

Hitting the same bug. This seems to have been an issue in the past already #2972 . Quite frustrating, especially as it is literally the first example in the README.

@deyaaeldeen deyaaeldeen mentioned this issue Nov 1, 2021
Merged
@deyaaeldeen
Copy link
Member

Hi @mszczepanczyk and @logicabrity, thanks a lot for reporting the issue with those details! I investigated it and found that there was a mistake in the most recent automatic generation of the package source code which caused a few issues. I just released a v10.0.2 patch, so please take a look and let me know if you find any other issues.

@deyaaeldeen deyaaeldeen added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Nov 1, 2021
@ghost
Copy link

ghost commented Nov 1, 2021

Hi @mszczepanczyk. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost
Copy link

ghost commented Nov 8, 2021

Hi @mszczepanczyk, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Nov 8, 2021
dpwatrous added a commit that referenced this issue Jan 7, 2022
@dpwatrous
[Batch] Use index.js as the rollup input file instead of batchService…
2564a93 
…Client.js

Fixes #18328
@dpwatrous dpwatrous mentioned this issue Jan 7, 2022
Merged
dpwatrous added a commit that referenced this issue Jan 7, 2022
@dpwatrous
[Batch] Use index.js as the rollup input file instead of batchService…
3958d0f 
…Client.js

Fixes #18328
dpwatrous added a commit that referenced this issue Jan 7, 2022
@dpwatrous
[Batch] Use index.js as the rollup input file instead of batchService…
d2b6a06 
…Client.js

Fixes #18328
dpwatrous added a commit that referenced this issue Jan 10, 2022
@dpwatrous
[Batch] Fix missing SharedKeyCredentials export (#19736)
82bc0dc 
* [Batch] Bump @azure/batch to 10.0.3

* [Batch] Use index.js as the rollup input file instead of batchServiceClient.js

Fixes #18328

* [Batch] Commented out skipped tests to pass CI
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
Batch Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@logicabrity @mszczepanczyk @deyaaeldeen @ramya-rao-a