Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Config] Secret reference sample update #18775

Merged
merged 7 commits into from
Nov 22, 2021
Merged

[App Config] Secret reference sample update #18775

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
80fea54
secret reference sample updated
HarshaNalluru Nov 22, 2021
523683e
remove comment
HarshaNalluru Nov 22, 2021
eaa60b9
update comments
HarshaNalluru Nov 22, 2021
4f931fe
Maor's feedback
HarshaNalluru Nov 22, 2021
2775f27
try catch error from sample
HarshaNalluru Nov 22, 2021
94dc5af
remove and
HarshaNalluru Nov 22, 2021
2cf6000
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-js into…
HarshaNalluru Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions sdk/appconfiguration/app-configuration/samples-dev/secretReference.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@ export async function main() {

const key = `secret${new Date().getTime()}`;

// setup
// - creates a secret using `@azure/keyvault-secrets`
// and
// - a corresponding secret reference config setting with `@azure/app-configuration`
// setup method creates
// - a secret using `@azure/keyvault-secrets`
// - and a corresponding secret reference config setting with `@azure/app-configuration`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think you can drop and

await setup(key);

console.log(`Get the added secretReference from App Config with key: ${key}`);
Expand Down
7 changes: 3 additions & 4 deletions sdk/appconfiguration/app-configuration/samples/v1/javascript/secretReference.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@ async function main() {

const key = `secret${new Date().getTime()}`;

// setup
// - creates a secret using `@azure/keyvault-secrets`
// and
// - a corresponding secret reference config setting with `@azure/app-configuration`
// setup method creates
// - a secret using `@azure/keyvault-secrets`
// - and a corresponding secret reference config setting with `@azure/app-configuration`
await setup(key);

console.log(`Get the added secretReference from App Config with key: ${key}`);
Expand Down
7 changes: 3 additions & 4 deletions sdk/appconfiguration/app-configuration/samples/v1/typescript/src/secretReference.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@ export async function main() {

const key = `secret${new Date().getTime()}`;

// setup
// - creates a secret using `@azure/keyvault-secrets`
// and
// - a corresponding secret reference config setting with `@azure/app-configuration`
// setup method creates
// - a secret using `@azure/keyvault-secrets`
// - and a corresponding secret reference config setting with `@azure/app-configuration`
await setup(key);

console.log(`Get the added secretReference from App Config with key: ${key}`);
Expand Down