[App Config] Secret reference sample update #18775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@diberry - it doesn't let me add you as a reviewer, please check the PR and let me know if this is good. |
5 tasks
pakrym
reviewed
Nov 22, 2021
| // - a corresponding secret reference config setting with `@azure/app-configuration` | ||
| // setup method creates | ||
| // - a secret using `@azure/keyvault-secrets` | ||
| // - and a corresponding secret reference config setting with `@azure/app-configuration` |
There was a problem hiding this comment.
nit: I think you can drop and
pakrym
approved these changes
Nov 22, 2021
… harshan/issue/app-config/18669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18669
The main change is that the
secretIdin the sample is updated fromrandom_stringtohttps://vault_name.vault.azure.net/secrets/random_stringparseKeyVaultSecretIdentifierto parse thesecretIdto get the name and vault url