Remove mock-fs, query-string, @types/query-string if they are not used #17297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
requested review from
bterlson,
deyaaeldeen,
EmmaZhu,
jeremymeng,
jiacfan,
ljian3377,
maorleger,
mikeharder,
praveenkuttappan,
sadasant,
schaabs,
vicancy,
vinjiang,
witemple-msft,
XiaoningLiu and
xirzec
as code owners
ghost
added
Azure.Identity
KeyVault
Storage
HarshaNalluru
approved these changes
Aug 27, 2021
deyaaeldeen
approved these changes
Aug 27, 2021
| @@ -469,7 +469,7 @@ packages: | |||
| integrity: sha512-CxaMaEjwtsmIhWtjHyGimKO7RmES0YxPqGQ9+jKqGygNlhG5NYHktDaiQu6w7k3g+I51VaLXtVSt+BVFd6VWfQ== | |||
| /@azure/identity/[email protected]: | |||
| dependencies: | |||
| '@azure/core-http': 1.2.6 | |||
| '@azure/core-http': 1.2.3 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that we were depending on older versions of
mock-fs,query-stringand@types/query-stringpackages in #17069Found that these were not really used in the packages where they were added as a dependency.
So, removing them.
This fixes #17107
The fix is partial for #17099 as mock-fs still needs to be updated in test-recorder