Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engsys] update dependency query-string and @types/query-string #17107

Closed
jeremymeng opened this issue Aug 24, 2021 · 1 comment · Fixed by #17297
Closed

[engsys] update dependency query-string and @types/query-string #17107

jeremymeng opened this issue Aug 24, 2021 · 1 comment · Fixed by #17297
Assignees
@ramya-rao-a
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Milestone
[2021] September

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Aug 24, 2021 •
edited
Loading

It was blocked by having to support IE11 but now we dropped IE support.

Previous PR to rollback upgrade: #4156
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 24, 2021
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Aug 24, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 24, 2021
@jeremymeng jeremymeng added this to the Backlog milestone Aug 24, 2021
@jeremymeng jeremymeng mentioned this issue Aug 24, 2021
Closed
@ramya-rao-a
Copy link
Contributor

Search query: https://github.com/Azure/azure-sdk-for-js/search?q=query-string&type=

No code is using this, so safe to remove from package.json files!

@ramya-rao-a ramya-rao-a self-assigned this Aug 26, 2021
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2021] September Aug 26, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Aug 27, 2021
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jan 5, 2022
CodeGen from PR 17107 in Azure/azure-rest-api-specs
ccc465f 
[DO NOT MERGE ] Introduce new scanners resource type (Azure#17107)

* introduce new scanners resource type

* fix error

* fixing errors

* fixing errors

* fix error

* fixing errors

* fixing comments

* adding new tag
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jan 11, 2022
CodeGen from PR 17232 in Azure/azure-rest-api-specs
6a8232c 
Revert "[DO NOT MERGE ] Introduce new scanners resource type (Azure#17107)" (Azure#17232)

This reverts commit 30fca88fa23112e4296322f38610e02da522d390.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
[2021] September
Development

Successfully merging a pull request may close this issue.

Remove mock-fs, query-string, @types/query-string if they are not used ramya-rao-a/azure-sdk-for-js
2 participants
@jeremymeng @ramya-rao-a