Update communication-common dependency to fix core-http transitive de… #16180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
requested review from
0rland0Wats0n,
ankitarorabit,
DominikMe and
a team
as code owners
ghost
added
the
JoshuaLai
approved these changes
Jul 2, 2021
maorleger
added a commit
that referenced
this pull request
Jul 7, 2021
…blob (#16182) We recently discovered an issue caused by bumping core-http by a major version (#15925) where if a transitive dependency is still allowing an older version we would end up with two versions of core-http / core-lro. This is a problem for two reasons: - bundle size - incompatibility of enums between two versions This was discovered via failed nightly tests and while some of this was fixed by #16180, we still need to audit all the packages and ensure that: For every package that moved to [email protected], all other dependencies of that package are pinned to a min-version that also uses [email protected] Luckily that is a very small number of packages - mainly communication (fixed) and storage (this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pendency
Communication-identity says it works with communication-common ^1.0.0 and core-http ^2.0.0
Communication-common is currently 1.1.0 when core-http dependency was updated to ^2.0.0. But communication-common 1.0.0 is compatible with core-http 1.2.6
So below combination will be a problem for users:
[email protected]
[email protected]
[email protected]